608948 - Contact photos not refreshing in address book view when updated programmatic-ally

Status: RESOLVED WORKSFORME

(Thunderbird :: Add-Ons: Extensions API, defect)

Description

[Daniel T]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.11) Gecko/20101013 Ubuntu/10.04 (lucid) Firefox/3.6.11
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.14) Gecko/20101006 Thunderbird/3.0.9

When an contact entry in the address book is modified manually to set/change the contact's picture, the new picture is reflected in the bottom of the address book pane.

This does not occur when setting the photoType and photoURI properties in an extension.

It appears that a local function "savePhoto" (abCardOverlay.js line:559) is called when this is done by the user interface, but there is no method to call this from the api interface.

It would be preferable for savePhoto to be called if required during a "modifyCard" call or when a new card is saved.   Alternatively an nsIAbCard exposed function to call savePhoto could be useful but less tidy.

Reproducible: Always

Steps to Reproduce:
1. card=addressbook.getCardForAddress("[e-mail]")
2. card.setProperty("PhotoType","web")
3. card.setProperty("PhotoURI","http://happyface.gif")
4. addressbook.updateCard(card);
5. open addressbook in gui, look at [e-mail] record (in preview) note photo not updated
6. open contact, look at photo tab, note new photo.
Actual Results:  
As described above, updated photo not shown in addressbook preview pane

Expected Results:  
new photo shown in preview pane

Comment 1

[Wayne Mery (:wsmwk)]

Still an issue in the new AB?

Comment 2

[Thomas D. (:thomas8)]

(In reply to Wayne Mery (:wsmwk) from comment #1)

Still an issue in the new AB?

No.

• Code involving savePhoto()/abCardOverlay.js is gone.
• The extension code of STR in comment 0 also no longer applicable, as we're now using webextensions API.
• Looks like John has just added contact photo support in Beta 107:
  https://webextension-api.thunderbird.net/en/latest/contacts.html#setphoto-id-file