Last Comment Bug 608966 - Make lightweight themes / personas work in the address book window
: Make lightweight themes / personas work in the address book window
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: Themes (show other bugs)
: Trunk
: All All
: -- normal (vote)
: seamonkey2.1b2
Assigned To: Jens Hatlak (:InvisibleSmiley)
:
Mentors:
Depends on: SM-lwtheme
Blocks:
  Show dependency treegraph
 
Reported: 2010-11-02 06:51 PDT by Jens Hatlak (:InvisibleSmiley)
Modified: 2010-11-05 02:04 PDT (History)
7 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
basic lwthemes support (2.52 KB, patch)
2010-11-02 07:26 PDT, Jens Hatlak (:InvisibleSmiley)
neil: review+
Details | Diff | Review
basic lwthemes support v1a [Checkin: comment 4] (2.49 KB, patch)
2010-11-03 05:08 PDT, Jens Hatlak (:InvisibleSmiley)
jh: review+
neil: superreview+
Details | Diff | Review
add Mac styling (1.65 KB, patch)
2010-11-03 14:57 PDT, Jens Hatlak (:InvisibleSmiley)
stefanh: review+
Details | Diff | Review
add Mac styling v1a (1.67 KB, patch)
2010-11-04 01:00 PDT, Jens Hatlak (:InvisibleSmiley)
jh: review+
Details | Diff | Review
add Mac styling v1b [Checkin: comment 14] (1.61 KB, patch)
2010-11-04 16:11 PDT, Jens Hatlak (:InvisibleSmiley)
jh: review+
Details | Diff | Review

Description Jens Hatlak (:InvisibleSmiley) 2010-11-02 06:51:57 PDT
+++ This bug was initially created as a clone of Bug #579739 +++

We should also make lwthemes work in the address book window.

The minimum is to add these two lines to the <window> of the XUL, cf. bug 579738:
        lightweightthemes="true"
        lightweightthemesfooter="status-bar"
Comment 1 Jens Hatlak (:InvisibleSmiley) 2010-11-02 07:26:45 PDT
Created attachment 487577 [details] [diff] [review]
basic lwthemes support
Comment 2 neil@parkwaycc.co.uk 2010-11-03 04:48:58 PDT
Comment on attachment 487577 [details] [diff] [review]
basic lwthemes support

>+#CardViewOuterBox:-moz-lwtheme,
>+treecols:-moz-lwtheme {
>+  -moz-appearance: none;
Neither element appears(!) to use -moz-appearance. r=me with this removed.

>+  color: -moz-dialogtext;
>+  background-color: -moz-dialog;
[The CardViewBox sets its own background colour. But not a colour. Oops.]
Comment 3 Jens Hatlak (:InvisibleSmiley) 2010-11-03 05:08:59 PDT
Created attachment 487877 [details] [diff] [review]
basic lwthemes support v1a [Checkin: comment 4]
Comment 4 Jens Hatlak (:InvisibleSmiley) 2010-11-03 05:26:50 PDT
Comment on attachment 487877 [details] [diff] [review]
basic lwthemes support v1a [Checkin: comment 4]

http://hg.mozilla.org/comm-central/rev/a1d081a1b45a
Comment 5 Stefan [:stefanh] (away until May 28) 2010-11-03 14:50:39 PDT
Comment on attachment 487877 [details] [diff] [review]
basic lwthemes support v1a [Checkin: comment 4]

suite/themes/classic/messenger/addressbook/addressbook.css

Please file at least a bug so we can fix this on Mac too.
Comment 6 Jens Hatlak (:InvisibleSmiley) 2010-11-03 14:57:18 PDT
Created attachment 488019 [details] [diff] [review]
add Mac styling

Sorry, I didn't think that we actually have a forked file for Mac for /everything/. It seems I either need to check much more or let others do this in the future. But then it's only trunk (YMMV).
Comment 7 Stefan [:stefanh] (away until May 28) 2010-11-03 15:45:13 PDT
Comment on attachment 488019 [details] [diff] [review]
add Mac styling

Thanks :-)

Just one thing:

+#searchInput:-moz-lwtheme {
+  opacity: .8;
+}

On mac, we differentiate between focused/not focused (findbar search box, url bar). That is, we just use an 0.9 opacity when the box is not focused.

So, instead of the above, please do "#searchInput:not([focused="true"]):-moz-lwtheme" and change the opacity to 0.9.
Comment 8 Jens Hatlak (:InvisibleSmiley) 2010-11-04 01:00:38 PDT
Created attachment 488147 [details] [diff] [review]
add Mac styling v1a

(In reply to comment #7)
> So, instead of the above, please do
> "#searchInput:not([focused="true"]):-moz-lwtheme" and change the opacity to
> 0.9.

To be completely in line with mac/navigator/navigator.css, I also took the liberty to change the order of the pseudo-classes.
Comment 9 Stefan [:stefanh] (away until May 28) 2010-11-04 01:03:23 PDT
Bah, missed the fact that we don't want the hardcoded colors.
Comment 10 Stefan [:stefanh] (away until May 28) 2010-11-04 10:33:18 PDT
Comment on attachment 488147 [details] [diff] [review]
add Mac styling v1a

+  color: -moz-dialogtext;
+  background-color: -moz-dialog;
OK, sorry for the confusion - but you don't want these, we have our own colors already.
Comment 11 Stefan [:stefanh] (away until May 28) 2010-11-04 11:30:51 PDT
Or rather I don't see any difference of not having the color set
Comment 12 Stefan [:stefanh] (away until May 28) 2010-11-04 11:58:18 PDT
(In reply to comment #10)
> Comment on attachment 488147 [details] [diff] [review]
> add Mac styling v1a
> 
> +  color: -moz-dialogtext;

This one is actually needed in the #CardViewOuterBox, but to make it easier for you (since it will require some fiddling to get it right), you can go for leaving both bakground/foreground out. I will file a bug on fine-tuning the lwtheme stuff later on anyway.
Comment 13 Jens Hatlak (:InvisibleSmiley) 2010-11-04 16:11:28 PDT
Created attachment 488352 [details] [diff] [review]
add Mac styling v1b [Checkin: comment 14]
Comment 14 Jens Hatlak (:InvisibleSmiley) 2010-11-04 16:19:13 PDT
Comment on attachment 488352 [details] [diff] [review]
add Mac styling v1b [Checkin: comment 14]

http://hg.mozilla.org/comm-central/rev/2161775b088d

Actually I adapted my contributor line to the file's style upon checkin. (Seems to be one of the things that you could only get consistent if all reviewers enforced them...)

Note You need to log in before you can comment on or make changes to this bug.