Closed
Bug 608966
Opened 14 years ago
Closed 14 years ago
Make lightweight themes / personas work in the address book window
Categories
(SeaMonkey :: Themes, defect)
SeaMonkey
Themes
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.1b2
People
(Reporter: InvisibleSmiley, Assigned: InvisibleSmiley)
References
Details
Attachments
(2 files, 3 obsolete files)
2.49 KB,
patch
|
InvisibleSmiley
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
1.61 KB,
patch
|
InvisibleSmiley
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #579739 +++ We should also make lwthemes work in the address book window. The minimum is to add these two lines to the <window> of the XUL, cf. bug 579738: lightweightthemes="true" lightweightthemesfooter="status-bar"
Assignee | ||
Comment 1•14 years ago
|
||
Comment 2•14 years ago
|
||
Comment on attachment 487577 [details] [diff] [review] basic lwthemes support >+#CardViewOuterBox:-moz-lwtheme, >+treecols:-moz-lwtheme { >+ -moz-appearance: none; Neither element appears(!) to use -moz-appearance. r=me with this removed. >+ color: -moz-dialogtext; >+ background-color: -moz-dialog; [The CardViewBox sets its own background colour. But not a colour. Oops.]
Attachment #487577 -
Flags: review?(neil) → review+
Assignee | ||
Comment 3•14 years ago
|
||
Attachment #487577 -
Attachment is obsolete: true
Attachment #487877 -
Flags: superreview?(neil)
Attachment #487877 -
Flags: review+
Updated•14 years ago
|
Attachment #487877 -
Flags: superreview?(neil) → superreview+
Assignee | ||
Comment 4•14 years ago
|
||
Comment on attachment 487877 [details] [diff] [review] basic lwthemes support v1a [Checkin: comment 4] http://hg.mozilla.org/comm-central/rev/a1d081a1b45a
Attachment #487877 -
Attachment description: basic lwthemes support v1a → basic lwthemes support v1a [Checkin: comment 4]
Assignee | ||
Updated•14 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1b2
Comment 5•14 years ago
|
||
Comment on attachment 487877 [details] [diff] [review] basic lwthemes support v1a [Checkin: comment 4] suite/themes/classic/messenger/addressbook/addressbook.css Please file at least a bug so we can fix this on Mac too.
Assignee | ||
Comment 6•14 years ago
|
||
Sorry, I didn't think that we actually have a forked file for Mac for /everything/. It seems I either need to check much more or let others do this in the future. But then it's only trunk (YMMV).
Attachment #488019 -
Flags: review?(stefanh)
Comment 7•14 years ago
|
||
Comment on attachment 488019 [details] [diff] [review] add Mac styling Thanks :-) Just one thing: +#searchInput:-moz-lwtheme { + opacity: .8; +} On mac, we differentiate between focused/not focused (findbar search box, url bar). That is, we just use an 0.9 opacity when the box is not focused. So, instead of the above, please do "#searchInput:not([focused="true"]):-moz-lwtheme" and change the opacity to 0.9.
Attachment #488019 -
Flags: review?(stefanh) → review+
Assignee | ||
Comment 8•14 years ago
|
||
(In reply to comment #7) > So, instead of the above, please do > "#searchInput:not([focused="true"]):-moz-lwtheme" and change the opacity to > 0.9. To be completely in line with mac/navigator/navigator.css, I also took the liberty to change the order of the pseudo-classes.
Attachment #488019 -
Attachment is obsolete: true
Attachment #488147 -
Flags: review+
Comment 9•14 years ago
|
||
Bah, missed the fact that we don't want the hardcoded colors.
Comment 10•14 years ago
|
||
Comment on attachment 488147 [details] [diff] [review] add Mac styling v1a + color: -moz-dialogtext; + background-color: -moz-dialog; OK, sorry for the confusion - but you don't want these, we have our own colors already.
Comment 11•14 years ago
|
||
Or rather I don't see any difference of not having the color set
Comment 12•14 years ago
|
||
(In reply to comment #10) > Comment on attachment 488147 [details] [diff] [review] > add Mac styling v1a > > + color: -moz-dialogtext; This one is actually needed in the #CardViewOuterBox, but to make it easier for you (since it will require some fiddling to get it right), you can go for leaving both bakground/foreground out. I will file a bug on fine-tuning the lwtheme stuff later on anyway.
Assignee | ||
Comment 13•14 years ago
|
||
Attachment #488147 -
Attachment is obsolete: true
Attachment #488352 -
Flags: review+
Assignee | ||
Comment 14•14 years ago
|
||
Comment on attachment 488352 [details] [diff] [review] add Mac styling v1b [Checkin: comment 14] http://hg.mozilla.org/comm-central/rev/2161775b088d Actually I adapted my contributor line to the file's style upon checkin. (Seems to be one of the things that you could only get consistent if all reviewers enforced them...)
Attachment #488352 -
Attachment description: add Mac styling v1b → add Mac styling v1b [Checkin: comment 14]
You need to log in
before you can comment on or make changes to this bug.
Description
•