608972 - Personas/Background without an author displays as "By undefined"

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Mike Kaply [:mkaply]]

If you have a persona that doesn't have an author, the Add-ons manager UI says "By undefined"

Looking in LightweightThemeManager.jsm, I see this:

431   this.__defineGetter__("creator", function() {
432     return new AddonManagerPrivate.AddonAuthor(aTheme.author);
433   });

No check for if author isn't specified, so addon manager will get "undefined" which is not equal to ""

Comment 1

[Mike Kaply [:mkaply]]

I don't have an easy way to create a diff right now, but here's the fix:


  this.__defineGetter__("creator", function() {
    return "author" in aTheme ? new AddonManagerPrivate.AddonAuthor(aTheme.author) : null;
  });

Comment 2

[Mike Kaply [:mkaply]]

Shouldn't fixes to LightweightThemeManager.jsm be in themes?

Comment 3

[Dave Townsend [:mossop]]

(In reply to comment #2)
> Shouldn't fixes to LightweightThemeManager.jsm be in themes?

No.

Comment 4

[Mike Kaply [:mkaply]]

Attachment: 608972.diff

Simple fix. I've tested and it fixes the issue.

Comment 5

[Mike Kaply [:mkaply]]

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/15ef13bfc4db52066e891211923152edce3be873
changeset:  15ef13bfc4db52066e891211923152edce3be873
user:       Mike Kaply <[e-mail]>
date:       Mon Aug 31 07:42:04 2015 -0500
description:
Bug 608972 - Make sure there is a theme author before using it. r=Mossop

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/15ef13bfc4db