609069 - about:rights shows XML parsing error

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aakash Desai [:aakashd]]

Build Id:
Mozilla/5.0 (maemol Linux armv7l; rv:2.0b7pre) Gecko/20101029 Firefox/4.0b8pre Fennec/4.0b2

and

Mozilla/5.0 (android Linux armv7l; rv:2.0b7pre) Gecko/20101029 Firefox/4.0b8pre Fennec/4.0b2

Note: regression range forthcoming

Steps to Reproduce:
1. go to about:rights

Actual Results:
XML Parsing error

Expected Results:
My rights page!

Comment 1

[Doug Turner (:dougt)]

undefined entity

&rights.pagetitle

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

This patch reverts the patch in bug 599669, which means we have forked aboutRights.dtd

We also need to fork aboutRights.xhtml (the file used in branded builds) so we can remove a reference to a DTD file (security.dtd) not bundled in Fennec, only in Firefox.

With this patch branded about:rights works. Unbranded about:rights was already working OK because it did not use the Firefox-only DTD file.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Bug 515109 would probably fix the situation enough that we could avoid forking the XHTML file.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch 2

This patch removes the "override" for the aboutRights.dtd, since ahboutRights.xhtml is now in mobile-browser.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 487704 [details] [diff] [review]
patch 2

r=me without the aboutRights.dtd addition.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed without aboutRights.dtd
http://hg.mozilla.org/mobile-browser/rev/d8387627520e (default)
http://hg.mozilla.org/mobile-browser/rev/a73da861034a (relbranch)

Comment 7

[Ayan Shah[:ashah]]

verified fixed on:
Mozilla/5.0(Android; Linux armv7l;rv2.0b8pre) Gecko/20101102 Firefox/4.0b8pre
Fennec/4.0b3pre

And

Mozilla/5.0(Maemo; Linux armv7l;rv2.0b8pre) Gecko/20101102 Firefox/4.0b8pre
Fennec/4.0b3pre