Closed Bug 609069 Opened 9 years ago Closed 9 years ago

about:rights shows XML parsing error

Categories

(Firefox for Android Graveyard :: General, defect, major)

defect
Not set
major

Tracking

(fennec2.0b2+)

VERIFIED FIXED
Tracking Status
fennec 2.0b2+ ---

People

(Reporter: aakashd, Assigned: mfinkle)

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

Build Id:
Mozilla/5.0 (maemol Linux armv7l; rv:2.0b7pre) Gecko/20101029 Firefox/4.0b8pre Fennec/4.0b2

and

Mozilla/5.0 (android Linux armv7l; rv:2.0b7pre) Gecko/20101029 Firefox/4.0b8pre Fennec/4.0b2

Note: regression range forthcoming

Steps to Reproduce:
1. go to about:rights

Actual Results:
XML Parsing error

Expected Results:
My rights page!
tracking-fennec: --- → ?
undefined entity

&rights.pagetitle
Assignee: nobody → mark.finkle
tracking-fennec: ? → 2.0b2+
Keywords: regression
Summary: [Regression] about:rights shows XML parsing error → about:rights shows XML parsing error
Attached patch patch (obsolete) — Splinter Review
This patch reverts the patch in bug 599669, which means we have forked aboutRights.dtd

We also need to fork aboutRights.xhtml (the file used in branded builds) so we can remove a reference to a DTD file (security.dtd) not bundled in Fennec, only in Firefox.

With this patch branded about:rights works. Unbranded about:rights was already working OK because it did not use the Firefox-only DTD file.
Attachment #487698 - Flags: review?(gavin.sharp)
Bug 515109 would probably fix the situation enough that we could avoid forking the XHTML file.
Attached patch patch 2Splinter Review
This patch removes the "override" for the aboutRights.dtd, since ahboutRights.xhtml is now in mobile-browser.
Attachment #487698 - Attachment is obsolete: true
Attachment #487704 - Flags: review?(gavin.sharp)
Attachment #487698 - Flags: review?(gavin.sharp)
Comment on attachment 487704 [details] [diff] [review]
patch 2

r=me without the aboutRights.dtd addition.
Attachment #487704 - Flags: review?(gavin.sharp) → review+
pushed without aboutRights.dtd
http://hg.mozilla.org/mobile-browser/rev/d8387627520e (default)
http://hg.mozilla.org/mobile-browser/rev/a73da861034a (relbranch)
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
verified fixed on:
Mozilla/5.0(Android; Linux armv7l;rv2.0b8pre) Gecko/20101102 Firefox/4.0b8pre
Fennec/4.0b3pre

And

Mozilla/5.0(Maemo; Linux armv7l;rv2.0b8pre) Gecko/20101102 Firefox/4.0b8pre
Fennec/4.0b3pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.