609138 - Dashboard should just use the search view

Status: VERIFIED FIXED

(Input Graveyard :: Dashboard, defect, P1)

Comment 1

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

Were you thinking that the homepage should use index() in search/view.py? Or rather that dashboard() in dashboard/view.py should use the search template instead of the dashboard template?

Comment 2

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

(In reply to comment #1)
> Were you thinking that the homepage should use index() in search/view.py? Or
> rather that dashboard() in dashboard/view.py should use the search template
> instead of the dashboard template?

This has pre-requisites not listed - but yes, essentially that.

We need to generate themes on search first.

The release dashboard will be a good model as that is just a search view and nothing else.

Comment 3

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

3.1 involves release dashboard using the search templates
3.2 maybe we can tackle the meta-data the beta dashboard has that search lacks.
3.3 at which point this will be trivial.

Comment 4

[Aakash Desai [:aakashd]]

Whoops, forgot to add a reason on punting this out:

The betas are going to be done for Firefox 4 when we begin this release and there's higher priority bugs to fix in this timeframe. I'd like to get this fixed ASAP, but when its more useful (i.e. Firefox 5 beta) and when the real fix (i.e. while visiting and often mentioned per search) can be fixed as well.

Comment 5

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Moving this out, this has a big dependency.

Comment 6

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

We're sort of unblocked on this for now as we had to remove trends on the dashboard :(

We'll bring it back for all searches soon, so we may as well unblock this.

Comment 8

[tofumatt [:tofumatt]]

Om nom nom this is done and checked in.

davedash gave this an r+ earlier today on IRC and I've been running it for the past two days. Seems like it's good for some QA.

Please let me know if anything's mixed up because of this; I essentially moved everything needed in dashboard over to search and deleted the dashboard app.

https://github.com/mozilla/input.mozilla.org/commit/46b9d3f93b88ffdfe69f8408abb29e1816b821fc

Comment 9

[Matt Brandt [:mbrandt]]

(In reply to comment #8)
> Om nom nom this is done and checked in.
> been running it for the past two days. Seems like it's good for some QA.

thx Matt... qa has been/is chewing on this :) and wants to chew for a bit longer.

Comment 10

[Matt Brandt [:mbrandt]]

In the veritable words of tofumatt... Om nom nom. QA verified.