Closed Bug 609160 Opened 9 years ago Closed 9 years ago

Wizard header labels should wrap

Categories

(Toolkit :: XUL Widgets, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
Tracking Status
blocking2.0 --- final+

People

(Reporter: philikon, Assigned: philikon)

References

Details

(Whiteboard: [hardblocker])

Attachments

(1 file, 1 obsolete file)

+++ This bug was initially created as a clone of Bug #608807 +++

Setup wizard title should wrap over two lines.
Blocks: 627166
Instead of porting the hack from bug 608807, we should just fix the wizard widgets to allow header labels to wrap (this blocks 627166). Morphing this bug into a Toolkit :: XUL Widgets bug.
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Component: Firefox Sync: UI → XUL Widgets
Product: Mozilla Services → Toolkit
QA Contact: sync-ui → xul.widgets
Summary: Sync UI: Setup dialog too small in l10n builds → Wizard header labels should wrap
Bug 627166 is a hardblocker, so this should be one too. Does that logic make sense? I think so.
blocking2.0: --- → ?
Whiteboard: [hardblocker?]
Attached patch v1 (obsolete) — Splinter Review
This puts the text for the wizard labels into a text node rather than a <label>'s 'value' attribute. That way they can wrap.
Attachment #510781 - Flags: review?(enndeakin)
Whiteboard: [hardblocker?] → [hardblocker?][has patch][needs review enn]
(In reply to comment #3)
> Created attachment 510781 [details] [diff] [review]
> v1
> 
> This puts the text for the wizard labels into a text node rather than a
> <label>'s 'value' attribute. That way they can wrap.

xbl:inherits="xbl:text=label" will do that for you.
(In reply to comment #4)
> xbl:inherits="xbl:text=label" will do that for you.

Oooh, didn't know about that one. Cool, thanks! Will round up a new patch.
Attached patch v2Splinter Review
Does the same thing as v1, but with much less code (using inherit="xbl:text=label")
Attachment #510781 - Attachment is obsolete: true
Attachment #511049 - Flags: review?(enndeakin)
Attachment #510781 - Flags: review?(enndeakin)
blocking2.0: ? → final+
Whiteboard: [hardblocker?][has patch][needs review enn] → [hardblocker][has patch][needs review enn]
Attachment #511049 - Flags: review?(enndeakin) → review+
http://hg.mozilla.org/mozilla-central/rev/60c07d9278f7
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [hardblocker][has patch][needs review enn] → [hardblocker]
will this be applied to Firefox branches?
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.