Closed Bug 609206 Opened 9 years ago Closed 9 years ago

Can't compile JS with --disable-methodjit

Categories

(Core :: JavaScript Engine, defect)

x86
Linux
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: romaxa, Unassigned)

References

Details

Attachments

(1 file)

Due to non implemented mjit for hardfp  toolchain we still decompiling methodjit from code.

and profilingEnabled under JS_METHODJIT define here http://mxr.mozilla.org/mozilla-central/source/js/src/jscntxt.h#2186, but not here http://mxr.mozilla.org/mozilla-central/source/js/src/jstracer.cpp#413
Attachment #487831 - Flags: review?(dmandelin)
Comment on attachment 487831 [details] [diff] [review]
+#ifdef JS_METHODJIT for profilingEnabled

Thanks for the patch. It's hard to keep all the different #ifdef combinations fully fresh.
Attachment #487831 - Flags: review?(dmandelin) → review+
(In reply to comment #1)
> Thanks for the patch. It's hard to keep all the different #ifdef combinations
> fully fresh.

I added bug 609413 to try to fix this.
Comment on attachment 487831 [details] [diff] [review]
+#ifdef JS_METHODJIT for profilingEnabled

This should be safe to apply
Attachment #487831 - Flags: approval2.0?
can we get approval for it?
Attachment #487831 - Flags: approval2.0? → approval2.0+
Keywords: checkin-needed
bug should be closed I guess
Status: NEW → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.