Closed
Bug 609206
Opened 14 years ago
Closed 14 years ago
Can't compile JS with --disable-methodjit
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: romaxa, Unassigned)
References
Details
Attachments
(1 file)
|
774 bytes,
patch
|
dmandelin
:
review+
benjamin
:
approval2.0+
|
Details | Diff | Splinter Review |
Due to non implemented mjit for hardfp toolchain we still decompiling methodjit from code. and profilingEnabled under JS_METHODJIT define here http://mxr.mozilla.org/mozilla-central/source/js/src/jscntxt.h#2186, but not here http://mxr.mozilla.org/mozilla-central/source/js/src/jstracer.cpp#413
Attachment #487831 -
Flags: review?(dmandelin)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 487831 [details] [diff] [review] +#ifdef JS_METHODJIT for profilingEnabled Thanks for the patch. It's hard to keep all the different #ifdef combinations fully fresh.
Attachment #487831 -
Flags: review?(dmandelin) → review+
|
||
Comment 2•14 years ago
|
||
(In reply to comment #1) > Thanks for the patch. It's hard to keep all the different #ifdef combinations > fully fresh. I added bug 609413 to try to fix this.
|
Reporter | |
Comment 3•14 years ago
|
||
Comment on attachment 487831 [details] [diff] [review] +#ifdef JS_METHODJIT for profilingEnabled This should be safe to apply
Attachment #487831 -
Flags: approval2.0?
|
|
Reporter | |
Comment 4•14 years ago
|
||
can we get approval for it?
|
||
Updated•14 years ago
|
Attachment #487831 -
Flags: approval2.0? → approval2.0+
|
|
Reporter | |
Updated•14 years ago
|
Keywords: checkin-needed
|
||
Comment 5•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/508fe9b3ecf1
|
|
Reporter | |
Comment 6•14 years ago
|
||
bug should be closed I guess
You need to log in
before you can comment on or make changes to this bug.
Description
•