Can't compile JS with --disable-methodjit

RESOLVED FIXED

Status

()

RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: romaxa, Unassigned)

Tracking

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
Created attachment 487831 [details] [diff] [review]
+#ifdef JS_METHODJIT for profilingEnabled

Due to non implemented mjit for hardfp  toolchain we still decompiling methodjit from code.

and profilingEnabled under JS_METHODJIT define here http://mxr.mozilla.org/mozilla-central/source/js/src/jscntxt.h#2186, but not here http://mxr.mozilla.org/mozilla-central/source/js/src/jstracer.cpp#413
Attachment #487831 - Flags: review?(dmandelin)
Comment on attachment 487831 [details] [diff] [review]
+#ifdef JS_METHODJIT for profilingEnabled

Thanks for the patch. It's hard to keep all the different #ifdef combinations fully fresh.
Attachment #487831 - Flags: review?(dmandelin) → review+

Comment 2

8 years ago
(In reply to comment #1)
> Thanks for the patch. It's hard to keep all the different #ifdef combinations
> fully fresh.

I added bug 609413 to try to fix this.
(Reporter)

Comment 3

8 years ago
Comment on attachment 487831 [details] [diff] [review]
+#ifdef JS_METHODJIT for profilingEnabled

This should be safe to apply
Attachment #487831 - Flags: approval2.0?
(Reporter)

Comment 4

8 years ago
can we get approval for it?

Updated

8 years ago
Attachment #487831 - Flags: approval2.0? → approval2.0+
(Reporter)

Updated

8 years ago
Keywords: checkin-needed
(Reporter)

Comment 6

8 years ago
bug should be closed I guess
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.