Closed Bug 609370 Opened 14 years ago Closed 14 years ago

create Makefile for socorro

Categories

(Socorro :: General, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rhelmer, Assigned: rhelmer)

Details

Attachments

(1 file)

I've been working with a local Makefile to run tests and install to my dev instance, and find it very helpful for local development. Here are some benefits:

* automatic virtualenv creation and dependency install
* "make install" (including config) for backend and PHP
* easy running of test, code coverage and pylint

The "install" target supports a prefix, so we could easily use it to generate tarballs for release purposes, if we want to move that way.

It is loosely based on the Makefile that the Sync project uses.
This replaces the build.sh we added for Hudson (bug 602559).
Also available for review on github:
https://github.com/rhelmer/socorro/commit/95e284f8f73e85005602ff3af7d62f2f4b5267a1
Assignee: nobody → robert
Status: NEW → ASSIGNED
Attachment #487993 - Flags: review?(lars)
Comment on attachment 487993 [details] [diff] [review]
makefile for socorro

Laura, what do you think of this? It replaces the Hudson-specific "build.sh" with a generic makefile that provides targets for:

* "make install" (w/ optional PREFIX, for making packages)
* run unit tests (creating virtualenv with dependencies if needed)
* any other stuff we use hudson for (code coverage, pylint, etc.)

Jabba and I were talking about having Hudson make a package (simple tarball built from using "make install"), and auto-installing staging from that. Once staging passes tests, we could check that same package into production.

Also, this should also be more useful/discoverable to devs than the scripts/build.sh is.
Attachment #487993 - Flags: review?(laura)
Comment on attachment 487993 [details] [diff] [review]
makefile for socorro

I concur, this is a lot easier to grok than the .sh.    Good work.
Attachment #487993 - Flags: review?(laura) → review+
Adding         Makefile
Deleting       scripts/build.sh
Transmitting file data .
Committed revision 2707.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Attachment #487993 - Flags: review?(lars)
Component: Socorro → General
Product: Webtools → Socorro
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: