609495 - "move to group" on app tab context menu should be hidden, not disabled

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[eyal gruss]

following bug 598598 comment 5

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch v1

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 500805 [details] [diff] [review]
patch v1

Please remove the test, it's not useful.

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch v2 (removed test as requested)

Comment 4

[Dão Gottwald [:dao]]

There's also browser_tabview_bug594176.js, which will probably fail with this change.

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch v3 (test for bug 594176 updated)

Sorry I was a little bit too hasty. Is it ok to just update the test for #594176?

Comment 6

[Dão Gottwald [:dao]]

You can update the test or remove it, as I think it will just continue to be a hurdle rather than catching a regression...

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch v4 (test for bug 594176 removed)

Ok, I removed the test.

Comment 8

[Dão Gottwald [:dao]]

Don't forget the tests' Makefile.in.

Comment 9

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch v5 (removed test for bug 594176 from Makefile.in)

Sorry, you're absolutely right.

Comment 10

[Tim Taubert [:ttaubert] (inactive)]

Pushed to try today. Passed.

Comment 11

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 500862 [details] [diff] [review]
patch v5 (removed test for bug 594176 from Makefile.in)

a=beltzner

Comment 12

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch for checkin

Comment 13

[:Margaret Leibovic]

http://hg.mozilla.org/mozilla-central/rev/abb38626bb9f