Closed Bug 609495 Opened 11 years ago Closed 11 years ago

"move to group" on app tab context menu should be hidden, not disabled

Categories

(Firefox :: Tabbed Browser, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 4.0b10

People

(Reporter: eyaler, Assigned: ttaubert)

References

(Blocks 1 open bug)

Details

(Keywords: polish)

Attachments

(1 file, 5 obsolete files)

following bug 598598 comment 5
Flags: in-litmus?
Attached patch patch v1 (obsolete) — Splinter Review
Assignee: nobody → tim.taubert
Status: NEW → ASSIGNED
Attachment #500805 - Flags: review?(mitcho)
Comment on attachment 500805 [details] [diff] [review]
patch v1

Please remove the test, it's not useful.
Attachment #500805 - Flags: review?(mitcho) → review+
Attachment #500805 - Attachment is obsolete: true
Attachment #500808 - Flags: approval2.0?
There's also browser_tabview_bug594176.js, which will probably fail with this change.
Attachment #500808 - Flags: approval2.0?
Sorry I was a little bit too hasty. Is it ok to just update the test for #594176?
Attachment #500808 - Attachment is obsolete: true
You can update the test or remove it, as I think it will just continue to be a hurdle rather than catching a regression...
Ok, I removed the test.
Attachment #500817 - Attachment is obsolete: true
Attachment #500822 - Flags: approval2.0?
Don't forget the tests' Makefile.in.
Attachment #500822 - Flags: approval2.0?
Sorry, you're absolutely right.
Attachment #500822 - Attachment is obsolete: true
Attachment #500862 - Flags: approval2.0?
Pushed to try today. Passed.
Comment on attachment 500862 [details] [diff] [review]
patch v5 (removed test for bug 594176 from Makefile.in)

a=beltzner
Attachment #500862 - Flags: approval2.0? → approval2.0+
Attachment #500862 - Attachment is obsolete: true
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/abb38626bb9f
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b10
You need to log in before you can comment on or make changes to this bug.