following bug 598598 comment 5
Assignee: nobody → tim.taubert
Status: NEW → ASSIGNED
Attachment #500805 - Flags: review?(mitcho)
Comment on attachment 500805 [details] [diff] [review] patch v1 Please remove the test, it's not useful.
Attachment #500805 - Flags: review?(mitcho) → review+
There's also browser_tabview_bug594176.js, which will probably fail with this change.
Sorry I was a little bit too hasty. Is it ok to just update the test for #594176?
Attachment #500808 - Attachment is obsolete: true
You can update the test or remove it, as I think it will just continue to be a hurdle rather than catching a regression...
Ok, I removed the test.
Don't forget the tests' Makefile.in.
Sorry, you're absolutely right.
Pushed to try today. Passed.
Comment on attachment 500862 [details] [diff] [review] patch v5 (removed test for bug 594176 from Makefile.in) a=beltzner
Attachment #500862 - Flags: approval2.0? → approval2.0+
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.