609513 - Users exist with an empty name

Status: RESOLVED WONTFIX

(addons.mozilla.org Graveyard :: Public Pages, defect, P4)

Description

[Truman Smith [:truman]]

There are at least two users with a blank name:
https://addons-next.allizom.org/en-US/firefox/user/5048079/
https://addons-next.allizom.org/en-US/firefox/user/152174/

When they post an add-on review there is no link to click on user profile.  Seen on preview and production.

Seen on add-ons:
https://addons-next.allizom.org/en-US/seamonkey/addon/10226/
https://addons-next.allizom.org/en-US/thunderbird/addon/4222/

Comment 1

[Wil Clouser [:clouserw]]

Both of those accounts are weird:
- Neither has names or emails
- Both have numeric usernames
- Neither has logged in since we started tracking logins
- both accounts were created years ago, but modified on 2010-09-02 within 20 minutes of each other

The first guy has 6 add-ons on the site, the second guy, despite his inappropriate profile pic, has contributed a lot of user reviews.  It looks like we ran 'convert_user_fields' and 'migrate_collection_users' within a day or so of their modified date.

There are 1089 other rows that match the same criteria as above.

Comment 2

[krupa raj[:krupa]]

This collection has no author- https://addons.allizom.org/en-US/mobile/collections/515624918855/favorites/

Comment 3

[krupa raj[:krupa]]

we should look at handling nameless users. Adding this to the AMO 5.12.5 queue

Comment 4

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Can we delete the nameless users since they've not logged in?

Comment 5

[Wil Clouser [:clouserw]]

(In reply to comment #4)
> Can we delete the nameless users since they've not logged in?

Don't we do that in the GC script after 6 months?  I don't think the script will delete them though since the guy is an add-on author.

Comment 6

[Wil Clouser [:clouserw]]

We don't GC users.  We should just fix these names in the db.  Make them the userid or something - just enough to get them in line with our current naming requirements.

Comment 7

[Wil Clouser [:clouserw]]

Thanks for filing this.  Due to resource constraints we are closing bugs which we won't realistically be able to fix.  If you have a patch that applies to this bug please reopen.

For more info see http://micropipes.com/blog/2014/09/24/the-great-add-on-bug-triage/