nsMimeTypes.h has wrong type for APPLICATION_HTTP_INDEX

VERIFIED FIXED in Future

Status

()

Core
Networking: HTTP
P3
trivial
VERIFIED FIXED
17 years ago
15 years ago

People

(Reporter: Bradley Baetz, Assigned: Bradley Baetz)

Tracking

Trunk
Future
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments)

(Assignee)

Description

17 years ago
Line 48 of nsMimeTypes.h has:

#define APPLICATION_HTTP_INDEX              "application/http-index"

Neither the define nor the string are used anywhere in mozilla - all places
which refer to the mime/type for an index file format use
application/http-index-format, as does the spec at
http://www.area.com/~roeber/file_format.html.

The define should be changed to match the spec and the usage within mozilla.

net.h also has the same problem.

Comment 1

17 years ago
http bugs to "Networking::HTTP"
Assignee: gagan → darin
Component: Networking → Networking: HTTP
Target Milestone: --- → M19

Comment 2

17 years ago
nominating for moz 0.9
Target Milestone: --- → mozilla0.9

Comment 3

17 years ago
changing milestone to FUTURE
Target Milestone: mozilla0.9 → Future
(Assignee)

Comment 4

17 years ago
Created attachment 28559 [details] [diff] [review]
patch

Comment 5

17 years ago
sr=darin, but consider these comments:

1) "mozilla/include/net.h" is dead.  this is part of the old netlib.  there
shouldn't be any consumers of this file.

2) there are many other places in necko which hard code "http-index-format"
what about making these use HTTP_INDEX_FORMAT as well?

fgrep http-index-format `find . -name '*.cpp'`

from mozilla/netwerk/ reveals the following set of files which should also
be fixed:

./base/src/nsFileStreams.cpp
./cache/filecache/nsDiskCacheRecordChannel.cpp
./protocol/file/src/nsFileChannel.cpp
./protocol/ftp/src/nsFtpConnectionThread.cpp
./protocol/ftp/src/nsFtpConnectionThread.cpp
./protocol/ftp/src/nsFtpConnectionThread.cpp
./streamconv/converters/nsFTPDirListingConv.cpp
./streamconv/converters/nsGopherDirListingConv.cpp


it'd be greatly appreciated if you would fix these as well.  thanks!
(Assignee)

Comment 6

17 years ago
Created attachment 28609 [details] [diff] [review]
fixes other instance in netwerk/
(Assignee)

Comment 7

17 years ago
I know net.h is obsolete, but I fixed it anyway just in case someone else was
including it somewhere.

The patches to nsFtpConnectionThread are attached to bug 68651.

I'm also reassigning this to me so that I can find it easily when I get arround
to applying for CVS write access :)
Assignee: darin → bbaetz

Comment 8

17 years ago
r=blake
(Assignee)

Comment 9

17 years ago
jag checked this in for me.
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 10

15 years ago
Verified per Bradley's comment
Status: RESOLVED → VERIFIED
QA Contact: tever → junruh
You need to log in before you can comment on or make changes to this bug.