609657 - Minefield does not display Firefox 3.x's exported bookmarks (in HTML format) like it did in 3.x

Status: RESOLVED WONTFIX

(Core :: DOM: HTML Parser, defect)

Description

[Stanley Chan]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; rv:2.0b8pre) Gecko/20101104 Firefox/4.0b8pre
Build Identifier: Mozilla/5.0 (Windows NT 6.1; rv:2.0b8pre) Gecko/20101104 Firefox/4.0b8pre

Simply put- the bookmarks exported from Minefield and Firefox stable in HTML no longer displays "correctly" with indents and line spacing for folders, descriptions, and line separators.

I say "correct" as in how Firefox 3.x-3.6 used to display the exported HTML file. I do not know if the tags are *incompatible* or nonstandard- thus not displaying correctly in a more standards-compliant browser.

Reproducible: Always

Steps to Reproduce:
1. Start Firefox stable (3.0.x or 3.6.x)
2. On the menu bar, hit *Bookmarks* -> *Show all Bookmarks*
3. Near the top, click *Import and Backup* -> *Export HTML..." Save the file somewhere and open it in Firefox stable. Notice how it displays and indents folders.
4. Open the same saved bookmark file on Firefox testing/ nightly. On my side, Minefield does not display it like FF 3.6 does.
Actual Results:  
Exported bookmarks in HTML does not have the formatting when opened in Minefield.

Expected Results:  
Bookmarks should display in a formatted manner (line spacing, font sizes, indents) in regards to folders and separators from the Bookmarks manager. Firefox stable displays the file "correctly"

Minefield nightly build (20101104 Firefox/4.0b8pre); latest trunk as of 04-Nov-2010

Addons enabled:
Ad-Block 1.3.1
Add-on Compatibility Reporter 0.7
Firebug 1.7X.0a4
NoScript 2.0.4
WOT 20100908

Theme:
Default with Blue Sky persona

Windows 7:
Aero disabled

Minefield is NOT installed- but running from the ZIP executable with the shortcut created to use another profile instead of the default

Comment 1

[Alice0775 White]

WFM
http://hg.mozilla.org/mozilla-central/rev/f7016571b472
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b8pre) Gecko/20101104 Firefox/4.0b8pre ID:20101104041903

Comment 2

[Stanley Chan]

(In reply to comment #1)
> WFM
> http://hg.mozilla.org/mozilla-central/rev/f7016571b472
> Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b8pre) Gecko/20101104
> Firefox/4.0b8pre ID:20101104041903

Might there be a difference between x8664 builds and x86? Also, would it be helpful if I uploaded my own exported bookmarks to the attachments? (Is it possible for me to delete them later, as they do contain some personal sites that I visit?)

Comment 3

[Stanley Chan]

Attachment: My exported bookmarks.

Comment 4

[Alice0775 White]

Attachment: screenshot

Screenshot shows opened your attachment 488286 [details] on 3.6.13pre and 4.0b8pre.

It seems to be no problem.

Comment 5

[Stanley Chan]

Attachment: local screenshot of affected machine

Interesting- I attached a screenshot my how my computer views the file.

Comment 6

[Shawn Wilsher :sdwilsh]

(In reply to comment #2)
> Might there be a difference between x8664 builds and x86?
They both would be the same 32-bit binary.

Comment 7

[Marco Bonardo [:mak] (Away July 4-13)]

Hm, I can reproduce also with a new profile so confirming
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b8pre) Gecko/20101104 Firefox/4.0b8pre
Not sure what could be the difference with Alice, I'm curious about that.

On the other side, this is not a valid html document (just look at the source, it's NETSCAPE-Bookmark-file-1) so I think it's not supposed to render as a html document.

The parser has changed to be conformant to html5, that could have changed how we handle the document. Could be wontfix since it's not a file supposed to be rendered, but could also hide a bug.
We should figure out what makes it render correctly for Alice, and eventually ask Sivonen or somone from layout what changed

Comment 8

[Marco Bonardo [:mak] (Away July 4-13)]

not sure if the new parser is involved, but cc-ing Sivonen for now.

Comment 9

[Alice0775 White]

My bad, i used user_pref("html5.enable", false);

Now i confirmed.

Comment 10

[Shawn Wilsher :sdwilsh]

(In reply to comment #9)
> My bad, i used user_pref("html5.enable", false);
> 
> Now i confirmed.
I think that means the parser is involved here too :)

Comment 11

[Henri Sivonen (:hsivonen) (on vacation)]

Well, this is interesting. The DOMs are *different*. It's not clear what's "right", though, since the HTML5 DOM seems to match more closely what the markup is trying to do...

AFAICT, Minefield with the HTML5 parser shows everything there's to show but with different indents. It seems to me this isn't a big problem. Is there some crucial dataloss happening here that I'm not noticing?

Comment 12

[Marco Bonardo [:mak] (Away July 4-13)]

No there is no dataloss known, I cc-ed you only because this could hide some parser bug.
The biggest problem this causes to us is just that the indentation is less usable, so if a user wants to view his bookmarks opening the file in the browser it will be a bit harder for him to find them.
But this is the old legacy format, so it's not going to be a blocker for us, just an annoyance

Comment 13

[Stanley Chan]

Can I request that once the bug is fixed that my copy of the bookmarks get removed? (Some personal information is inside that, and I don't want that getting out into the wild...)

Thanks very much; I hope you understand.

Comment 14

[Henri Sivonen (:hsivonen) (on vacation)]

Given comment 11 and comment 12, marking as WONTFIX.

Comment 15

[Reed Loden [:reed]]

The content of attachment 488286 [details] has been deleted by
    Reed Loden [:reed] (busy; not reading bugmail regularly) <[e-mail]>
who provided the following reason:

Requested by attachment submitter on the grounds that the file contains personal data.

The token used to delete this attachment was generated at 2010-11-23 08:25:21 PST.