609778 - Put jquery based mozilla-expanders.js in production

Status: RESOLVED FIXED

(www.mozilla.org :: General, defect)

Description

[Anthony Ricaud (:rik)]

On trunk, mozilla-expanders.js is based on jQuery instead of YUI. We should put it in production.

Here is a quick grep of files using it.
I've removed all locale versions of firefox/security/identity/index.html

en-GB/mobile/faq/index.html:    <script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.0/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.0.1/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.0.10/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.0.11/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.0.11rc/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.0.12/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.0.12rc/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.0.13/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.0.13rc/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.0.14/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.0.14rc/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.0.15/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.0.15rc/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.0.16/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.0.16rc/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.0.17/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.0.17rc/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.0.18/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.0.18rc/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.0.19/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.0.19rc/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.0.1rc/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.0.2/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.0.2rc/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.0.3/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.0.3rc/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.0.4/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.0.4rc/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.0.5/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.0.5rc/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.0.6/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.0.6rc/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.0.7/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.0.7rc/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.0.8/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.0.9/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.0.9rc/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.1b1/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.1b2/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.1b3/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.5/releasenotes/index.html:    <script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.5.1/releasenotes/index.html:    <script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.5.10/releasenotes/index.html:    <script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.5.10rc/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.5.11/releasenotes/index.html:    <script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.5.11rc/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.5.12/releasenotes/index.html:    <script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.5.12rc/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.5.13/releasenotes/index.html:    <script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.5.1rc/releasenotes/index.html:    <script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.5.2/releasenotes/index.html:    <script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.5.2rc/releasenotes/index.html:    <script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.5.3/releasenotes/index.html:    <script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.5.3rc/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.5.4/releasenotes/index.html:    <script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.5.4rc/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.5.5/releasenotes/index.html:    <script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.5.6/releasenotes/index.html:    <script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.5.6rc/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.5.7/releasenotes/index.html:    <script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.5.7rc/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.5.8/releasenotes/index.html:    <script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.5.8rc/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.5.9/releasenotes/index.html:    <script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.5.9rc/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.5b4/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.5pre/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.5rc1/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.6/firstrun/a/index.html:    <script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.6/firstrun/d/index.html:    <script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.6/releasenotes/index.html:    <script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.6.10/releasenotes/index.html:    <script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.6.2/releasenotes/index.html:    <script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.6.2rc/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.6.3/releasenotes/index.html:    <script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.6.3plugin1/releasenotes/index.html:        <script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.6.4/releasenotes/index.html:    <script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.6.4rc/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.6.6/releasenotes/index.html:    <script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.6.7/releasenotes/index.html:    <script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.6.7rc/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.6.8/releasenotes/index.html:    <script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.6.9/releasenotes/index.html:    <script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.6.9rc/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.6a2/releasenotes/index.html:    <script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.6b1/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.6b2/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.6b3/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.6b4/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.6b5/releasenotes/index.html:  <script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.6rc1/releasenotes/index.html:  <script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/3.6rc2/releasenotes/index.html:  <script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/4.0b1/releasenotes/index.html:  <script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/4.0b2/releasenotes/index.html:  <script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/4.0b3/releasenotes/index.html:  <script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/4.0b4/releasenotes/index.html:  <script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/4.0b5/releasenotes/index.html:  <script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/4.0b6/releasenotes/index.html:  <script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/phishing-protection/firefox2/index.html:<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/phishing-protection/index.html:<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/security/identity/index.html:<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/switch.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/firefox/update/index.html:        <script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/legal/privacy/notices-firefox/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/mobile/1.0/releasenotes/index.html:    <script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/mobile/1.0.1/releasenotes/index.html:    <script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/mobile/1.1/releasenotes/index.html:    <script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/mobile/1.1b1/releasenotes/index.html:    <script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/mobile/1.1rc1/releasenotes/index.html:    <script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/mobile/2.0a1/releasenotes/index.html:    <script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/mobile/4.0b1/releasenotes/index.html:    <script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/mobile/4.0b2/releasenotes/index.html:    <script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/mobile/faq/index.html:    <script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/mobile/home/1.0/releasenotes/index.html:    <script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/mobile/home/1.0.2/releasenotes/index.html:    <script type="text/javascript" src="/js/mozilla-expanders.js"></script>
en-US/mobile/home/faq/index.html:    <script type="text/javascript" src="/js/mozilla-expanders.js"></script>
includes/footers/firefox/geolocation.inc.php:<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
includes/headers/3.6.2-3/firstrun.inc.php:    <script type="text/javascript" src="{$config['static_prefix']}/js/mozilla-expanders.js"></script>
includes/headers/3.6.2-3/whatsnew.inc.php:    <script type="text/javascript" src="{$config['static_prefix']}/js/mozilla-expanders.js"></script>
includes/headers/mobile/faq.php:    <script type="text/javascript" src="/js/mozilla-expanders.js"></script>
includes/min/groupsConfig.php:        '//js/mozilla-expanders.js',
it/firefox/phishing-protection/index.html:<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
pl/mobile/faq/index.html:    <script type="text/javascript" src="/js/mozilla-expanders.js"></script>
pt-BR/firefox/3.0/releasenotes/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>
pt-BR/firefox/3.5/releasenotes/index.html:    <script type="text/javascript" src="/js/mozilla-expanders.js"></script>
pt-BR/firefox/3.6/releasenotes/index.html:    <script type="text/javascript" src="/js/mozilla-expanders.js"></script>
pt-BR/legal/privacy/notices-firefox/index.html:	<script type="text/javascript" src="/js/mozilla-expanders.js"></script>

Comment 1

[Anthony Ricaud (:rik)]

Steven,

As I was finishing on bug 589315, I've filed this bug. Is there anything blocking r74425 from going into production?

Comment 2

[Steven Garrity [:sgarrity]]

(In reply to comment #1)
> As I was finishing on bug 589315, I've filed this bug. Is there anything
> blocking r74425 from going into production?

Is jquery being included on all of those pages?

Comment 3

[Anthony Ricaud (:rik)]

That's what r74425 is doing: including jQuery on all those pages. I'm just wondering why it hasn't been pushed in prod yet.

And if we missed any page, it will just show the content expanded which is not a big deal and can be fixed easily.

Comment 4

[Steven Garrity [:sgarrity]]

(In reply to comment #3)
> That's what r74425 is doing: including jQuery on all those pages. I'm just
> wondering why it hasn't been pushed in prod yet.

Ah, right - my own commit!

This should be ok to push to production. The primary concern is that the YUI includes that were removed on those pages could have been used by something else on the page. I checked for that and didn't find any such cases, but a second set of eyes wouldn't hurt.

Comment 5

[Anthony Ricaud (:rik)]

So I've pushed r74425 on stage with r76950.

QA needed on stage:
- We've changed all locales for firefox/security/identity/index.html
- We've changed a lot of releasenotes
- And the following list
en-GB/mobile/faq/index.html
en-US/firefox/3.6/firstrun/a/index.html
en-US/firefox/3.6/firstrun/d/index.html
en-US/firefox/phishing-protection/firefox2/index.html
en-US/firefox/phishing-protection/index.html
en-US/firefox/switch.html
en-US/firefox/update/index.html
en-US/legal/privacy/notices-firefox/index.html
en-US/mobile/faq/index.html
en-US/mobile/home/faq/index.html
includes/footers/firefox/geolocation.inc.php
includes/headers/3.6.2-3/firstrun.inc.php
includes/headers/3.6.2-3/whatsnew.inc.php
includes/headers/mobile/faq.php
includes/min/groupsConfig.php
it/firefox/phishing-protection/index.html
pl/mobile/faq/index.html
pt-BR/legal/privacy/notices-firefox/index.html

Comment 6

[raymond [:retornam] (inactive)]

Attachment: screenshot

http://www-trunk.stage.mozilla.com/ca/m/ is broken

Comment 7

[Alex Buchanan [:abuchanan]]

looking good on production

(In reply to comment #6)
> Created attachment 491619 [details]
> screenshot
> 
> http://www-trunk.stage.mozilla.com/ca/m/ is broken

FTR, this is related to a different bug, and is on trunk only.