609838 - Fennec double-tap zoom is broken with HW acceleration enabled

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Oleg Romashin (:romaxa)]

Take upstream nightly GTK fennec build for linux desktop

open some page like "file:///usr/share" or google.com

initiate zoom with double tap and zoom-out with another double tap:

RESULT:
Page looks broken and corrupted (different parts of the screen contain page zoomed with different values.)

Comment 1

[Oleg Romashin (:romaxa)]

Attachment: Screenshoot

Comment 2

[Oleg Romashin (:romaxa)]

ok, I've tested this bug with hacky patch from bug 
https://bugzilla.mozilla.org/attachment.cgi?id=488743&action=edit

And it seems zoomin/out correctly with that hack.

cjones: does it make sense?

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Hmm, not really :(.  I wonder if there's some race condition here, perhaps with texture-uploading?  If you added a sleep after the TextureImage update and the problem went away, that would be suspicious.  (My understanding is that tex*image2d is supposed to copy bits if it needs to, in order to avoid these races, but who knows.)

Comment 4

[Oleg Romashin (:romaxa)]

Attachment: Fixed zoom problem, and perf of transparent HTML5 video

Comment 5

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 489512 [details] [diff] [review]
Fixed zoom problem, and perf of transparent HTML5 video

\o/

Comment 6

[Oleg Romashin (:romaxa)]

Attachment: Another problem

When I apply patch with resolution fix, then it is fixing zoom problem and HTML5 performance, but I see these rendering problem when I opening http://camendesign.com/code/video_for_everybody/test.html
and scroll it down.

Comment 7

[Oleg Romashin (:romaxa)]

Can we land it?

Comment 8

[Oleg Romashin (:romaxa)]

http://hg.mozilla.org/mozilla-central/rev/811a97636ef2