60984 - Shouldn't be able to drag certain nodes

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect, P3)

Description

[Blake Ross]

You can still drag the sidebar header, the status bar, <browser/>'s, etc.  The 
fix for 59799 (the comparison of event.target and event.originalTarget) didn't 
seem to help. Alec, if you get to a patch for this first, please also remove 
the global var wasDrag from contentAreaDD.js.  I added that while trying 
something out, but it must have slipped into one of my patches (it's unused).  
Thanks!

Comment 1

[Blake Ross]

gSourceDocument should also be removed.

Comment 2

[Alec Flett]

We need to figure out a generic way of deciding if we can drag something.
My fix to not drag XBL nodes doesn't seem to be enough.
Possible solutions are:
- blacklist of specific nodes like <browser> or <sidebarheader>
  I object to this because we'll never get EVERY node, and it's not generic
- adding an attribute to the node like preventdrag="true"
  I like this idea.. it seems like overkill at first, but I think we do similar
attribute checking elsewhere
- try to come up with more tricky rules (like the .originalTarget vs. .target)
  .. but I'm not sure we'll be able to come up with all the right rules

Comment 3

[Blake Ross]

Alec, I think hyatt just fixed this for you -- at least, his checkin comment 
suggests that, and it's working in my tip build.  He also said your 
event.target / event.originalTarget comparison was bogus.