Last Comment Bug 609848 - Tagged uris are not listed under tags
: Tagged uris are not listed under tags
Status: NEW
:
Product: Firefox
Classification: Client Software
Component: Bookmarks & History (show other bugs)
: unspecified
: x86 Windows XP
: -- normal with 1 vote (vote)
: ---
Assigned To: Nobody; OK to take it and work on it
:
: Marco Bonardo [::mak]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-11-05 00:07 PDT by ithinc
Modified: 2010-11-30 11:17 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments

Description ithinc 2010-11-05 00:07:37 PDT
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; zh-CN; rv:1.9.2.12) Gecko/20101026 Firefox/3.6.12 (.NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; zh-CN; rv:1.9.2.12) Gecko/20101026 Firefox/3.6.12 (.NET CLR 3.5.30729)

Some tagged uris are not listed under tags.

Reproducible: Always

Steps to Reproduce:
1. PlacesUtils.tagging.tagURI(makeURI("http://asdf.com"), ["asdf"]);
2.
3.
Actual Results:  
The tag "asdf" is listed under Recent Tags, but the uri "http://asdf.com" is not listed under tag "asdf".
Comment 1 Marco Bonardo [::mak] 2010-11-05 02:56:16 PDT
I need better steps to reproduce, what you say above seems to work fine.
Is this a problem only in Recent Tags? does the uri appear in the Library under Tags?
Comment 2 ithinc 2010-11-05 03:46:00 PDT
No, it doesn't appear in the Library either.

Steps: Open a javascript shell, and execute the above. Note that the uri should be not bookmarked before.
Comment 3 Marco Bonardo [::mak] 2010-11-05 04:08:20 PDT
so, yes, the API does not tell anything, and that's bad, taggingURI assumes that the uri is bookmarked somewhere, we usually add to unsorted bookmarks before tagging. 
To clarify tagging service creates the entry but tag queries are doing a remapping of the entries to real bookmarks. If a real bookmark is not found the tagged uri won't be shown.

For your case you can just check if uri is already bookmarked, if not add it, check the code in PlacesUIUtils.ptm.tagURI(uri,[tag]);

We can most likely fix this for FX4.0 too.
Comment 4 ithinc 2010-11-05 07:42:08 PDT
For my case, I don't want to add a bookmark in the unsorted bookmarks folder. I just want the tagged uri shown under tags.
Comment 5 Marco Bonardo [::mak] 2010-11-30 11:17:46 PST
there is no other way than adding a bookmark, 1 tag = 1 bookmark

Note You need to log in before you can comment on or make changes to this bug.