Add kSWF12 constant to Version enum in avmplus::BugCompatibility

VERIFIED FIXED

Status

Tamarin
Virtual Machine
VERIFIED FIXED
8 years ago
7 years ago

People

(Reporter: Jeff Mott, Assigned: Brent Baker)

Tracking

Details

Attachments

(1 attachment)

1.06 KB, patch
pnkfelix
: review+
Lars T Hansen
: feedback+
Details | Diff | Splinter Review
(Reporter)

Description

8 years ago
User-Agent:       Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.1; WOW64; Trident/4.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C; .NET4.0E)
Build Identifier: Head

Need new version to enable fixing of bugs that are SWF 12 and up only

Reproducible: Always

Steps to Reproduce:
1. Look at code in AvmCore.h and AvmCore.cpp
2.
3.
Actual Results:  
n/a

Expected Results:  
n/a

I'm unable to generate a patch file, can't get tools configured and tired of fussing with them.  Changes are below, and in Flash Player Perforce change 743604.

In AvmCore.h

        enum Version
        {
            kSWF9,              // SWF9  (Flash Player 9.x)
            kSWF10,             // SWF10 (Flash Player 10.0 & 10.1)
            kSWF11,             // SWF11 (Flash Player 10.2 Spicy)
            kSWF12,             // SWF12 (Flash Player 10.3 Serrano)

            VersionCount,

            kLatest = kSWF12    // alias for "most recent"; will be changed as new versions are added.
                                // note that this comes *after* VersionCount.
        };


In AvmCore.cpp

    /*static*/ uint32_t const BugCompatibility::kNames[BugCompatibility::VersionCount] =
    {
        9,
        10,
        11,
        12
    };
Assignee: nobody → fklockii
(Assignee)

Comment 1

8 years ago
Created attachment 488464 [details] [diff] [review]
patch
Attachment #488464 - Flags: review?(stejohns)
(Assignee)

Updated

8 years ago
Attachment #488464 - Flags: review?(stejohns) → review?(fklockii)
Assignee: fklockii → brbaker
Comment on attachment 488464 [details] [diff] [review]
patch

ship it!
Attachment #488464 - Flags: review?(fklockii) → review+
(Assignee)

Comment 3

8 years ago
Comment on attachment 488464 [details] [diff] [review]
patch

Dan/Lars is having code names in the source ok or should they be removed before I push this patch. I think having a code name mapping here is useful.
Attachment #488464 - Flags: feedback?(lhansen)
(Assignee)

Updated

8 years ago
Attachment #488464 - Flags: feedback?(dansmith)

Comment 4

8 years ago
Comment on attachment 488464 [details] [diff] [review]
patch

The code names and flash version numbers are tied together already in bugzilla (for the target field) so it doesn't seem bad to have them here; technically I'd probably go with "TBD Serrano" rather than "10.3 Serrano" but I don't know that it matters much.
Attachment #488464 - Flags: feedback?(lhansen) → feedback+
(Assignee)

Comment 5

8 years ago
Comment on attachment 488464 [details] [diff] [review]
patch

Patch pushed with code names but kept the latest SWF number FP version as TBD, matching what was there before:

-            kSWF11,             // SWF11 (Flash Player TBD)
+            kSWF11,             // SWF11 (Flash Player 10.2 Spicy)
+            kSWF12,             // SWF12 (Flash Player TBD Serrano)



Pushed as 5511:793e0c56465a
Attachment #488464 - Flags: feedback?(dansmith)
(Assignee)

Updated

8 years ago
Status: UNCONFIRMED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(Assignee)

Updated

7 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.