Build script used to deploy shell on remote SSH machine needs to also update runner script

VERIFIED FIXED

Status

Tamarin
Build Config
VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: Brent Baker, Assigned: Chris Peyer)

Tracking

unspecified
Bug Flags:
flashplayer-triage +

Details

(Whiteboard: buildbot)

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

7 years ago
We have scripts that we use in the build system that let us deploy and run an avmshell on a remote host via SSH. The script that deploys the shell to the remote host [1] makes sure that there are no old shells on the machine, deploys the new shell and then confirms that the deployed shell is the version that was requested.

The problem with this is that we have to actually run the avmshell via a script on the remote host so that we can capture the exit code of the shell and return that back to the calling machine. This is handled by ssh-shell-runner.sh. The problem here is that this script is not updated by the deployer script, so any changes made to this script require that it be manually deployed to the remote ssh machine.

All we need to do is add another scp call in the deployer script to deploy the runner (and maybe another to ensure that it executes properly)


[1] http://hg.mozilla.org/tamarin-redux/file/tip/build/buildbot/slaves/all/ssh-shell-deployer.sh
Flags: flashplayer-triage+
Flags: flashplayer-qrb?
(Assignee)

Comment 1

7 years ago
Created attachment 488561 [details] [diff] [review]
Copy ssh-shell-runner.sh on every build
Assignee: nobody → cpeyer
Status: NEW → ASSIGNED
Attachment #488561 - Flags: review?(brbaker)
(Reporter)

Comment 2

7 years ago
Comment on attachment 488561 [details] [diff] [review]
Copy ssh-shell-runner.sh on every build

If the copying of the runner script fails then there is no point it copying over the avmshell, might as well exit in the test block.

Is the execute bit still properly set on the file after copying it to the remote machine? If not you will have to add in an ssh call to set the execute bit on the script.

Personal nit: I am starting to dislike "test" blocks simply because I can never remember if || means the test was successful or if && means it was successful.
Attachment #488561 - Flags: review?(brbaker) → review-
(Assignee)

Comment 3

7 years ago
Created attachment 488919 [details] [diff] [review]
Updated patch

Patch addressing issues in comment #2.  Also changed the filename check to use if instead of test.
Attachment #488561 - Attachment is obsolete: true
Attachment #488919 - Flags: review?(brbaker)
(Reporter)

Updated

7 years ago
Attachment #488919 - Flags: review?(brbaker) → review+
(Assignee)

Comment 4

7 years ago
pushed to redux:

http://hg.mozilla.org/tamarin-redux/rev/ded74e8bccaf
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Assignee)

Updated

7 years ago
Status: RESOLVED → VERIFIED
(Reporter)

Updated

7 years ago
Flags: flashplayer-qrb?
You need to log in before you can comment on or make changes to this bug.