Closed
Bug 609996
Opened 14 years ago
Closed 14 years ago
search.xml autocomplete needs tweak to be cleanly extensible
Categories
(Thunderbird :: Search, defect)
Thunderbird
Search
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.3a1
People
(Reporter: davida, Assigned: davida)
Details
Attachments
(1 file)
|
940 bytes,
patch
|
davida
:
review+
|
Details | Diff | Splinter Review |
add-ons can insert completers in glautocomp.js, and it works beautifully. The only problem is that the observer in search.xml expects that the completion result is one of the built-in ones. An add-on can register another observer for the autocomplete-did-enter-text notification and handle it. However, the search.xml observer will complain if the row object doesn't have a nounDef for example. Proposed patch attached.
|
Assignee | |
Updated•14 years ago
|
Attachment #488556 -
Flags: review?(bugmail)
|
|
Assignee | |
Updated•14 years ago
|
Attachment #488556 -
Attachment is patch: true
Attachment #488556 -
Attachment mime type: application/octet-stream → text/plain
|
|
Assignee | |
Comment 1•14 years ago
|
||
Comment on attachment 488556 [details] [diff] [review] patch in email, r=asuth.
Attachment #488556 -
Flags: review?(bugmail) → review+
|
||
Updated•14 years ago
|
Keywords: checkin-needed
|
||
Comment 2•14 years ago
|
||
Checked in: http://hg.mozilla.org/comm-central/rev/848ebd9d7828
Assignee: nobody → david.ascher
Status: NEW → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.3a1
You need to log in
before you can comment on or make changes to this bug.
Description
•