61011 - [access]can't close some JS windows with keybinding (cmd-W / ctrl-W)

Status: RESOLVED WORKSFORME

(Core :: XUL, defect, P3)

Description

[Kathleen :Brade]

(This may be a duplicate but I haven't been able to find another bug on this
particular issue yet.  Also, I'm not sure how to reproduce this.  :-/)

The following is reported by Jason Alcock on 11/15/2000 at
http://www.macintouch.com/netscape6.html:

Doesn't accept cmd-W to close some javascript-opened windows.

Comment 1

[Peter Trudelle]

->saari, in hopes that he will recognize a reproducible defect in keybinding
here.  cc danm for possible window closing problem.

Comment 2

[John Morrison]

lorca -- did you file a bug on this point? (I thought you had).

Comment 3

[Dan M]

Too vague to be useful. cmd-W is known to work in general. I'd close it WFM.

Comment 4

[John Morrison]

Attachment: testcase; windows created as window.open don't work with cmd|ctrl-W without some '..bars' set.

Comment 5

[John Morrison]

I guess danm missed the double-secret memo that said we should break this 
keybinding for popup advertisements in order to increase viewing time. 
(e.g., windows without a full complement of toolbar, location, etc.). 

[Note: this applies to windows as well, and under all cases on linux].

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Saari had bug 56343, which seems similar, marked as mozilla 1.0 TM.  I'll attach
a testcase I wrote before I found either of these bugs...  (Based on 4.x
behavior, hotkeys=no should not affect whether Meta-W works.)

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: additional testcase

Comment 8

[Loco]

*** Bug 56343 has been marked as a duplicate of this bug. ***

Comment 9

[Loco]

I think this topic seems familiar, I've seen it before, but don't know if I ever 
wrote it up-although I am fairly sure there was a similar issue that I did write 
up.
On another note, the info from the "duplicate" bug:
From Steve Dagley (the original submission for this bug):
http://www.apple.com/trailers/disney/monsters_inc/
Summary:
JavaScript created windows don't appear to have keyboard event handlers hooked up
His blurb:
It appears that for JavaScript created windows the keyboard event handlers, such 
as for close window, aren't hooked up even tho the menu item is present and lists 
a command shortcut.  From the example URL on the Apple QuickTime movie trailer 
site select one of the frame sizes for the Monster Inc. trailer.  Observe that it 
brings up a new window.  Observe that this window isn't closed if you use the 
Command-W keyboard shortcut for the Close menu item.  Observe that directly 
selecting the Close menu item or clicking in the go away box for the window does 
close the window.

Comment 10

[Barrett Lindstrom]

I've also noticed that it happens on other windows, not just javascript opened 
windows.  If you just choosing File->New Navigator Window, the new window will 
also not close with cmd-W.  I've reproduced this on HPUX build #20010214 and 
Linux build #20010131.

Comment 11

[Peter Trudelle]

->aaronl

Comment 12

[John Morrison]

With jag's fix to focus content if the locationbar is not visible, then this 
works for mac and win32, and for almost all cases on Linux [for the test cases
listed above].

The condition that it fails on Linux is that if the urlbar is showing, it gets 
focus, and the urlbar has a binding for Ctrl-W, which is to wipe the current 
line. So that eats the event, and the window close is not triggered. I don't 
think that's really a bug (awkward, yes, bug, not really). But I'll leave to 
Mr. Accessibility to make the final call of WFM.

Comment 13

[Aaron Leventhal]

Similar to bug 75191

Comment 14

[gsa]

seeing this bug in mac build id: 2001092608

Comment 15

[Ben Goodger (use ben at mozilla dot org for email)]

Is this bug really mine? 

Comment 16

[Jesse Ruderman]

See also bug 108244, "Nothing is focused when opening a new window[CTRL+N] 
without a URL bar".

Comment 17

[Ben Goodger (use ben at mozilla dot org for email)]

ah, yes, I can fix this. 

Comment 18

[Jesse Ruderman]

WFM on jrgm's testcase.

Comment 19

[Asa Dotzler [:asa]]

I thikn this is all wrapped up.