610189 - Error: aOldNode is undefined

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, defect)

Description

[ithinc]

User-Agent:       Mozilla/5.0 (Windows NT 5.1; rv:2.0b8pre) Gecko/20101106 Firefox/4.0b8pre
Build Identifier: Mozilla/5.0 (Windows NT 5.1; rv:2.0b8pre) Gecko/20101106 Firefox/4.0b8pre

Error: aOldNode is undefined
Source File: chrome://browser/content/places/treeView.js
Line: 424

Reproducible: Always

Steps to Reproduce:
1. Drag the current tab to bookmarks toolbar
2. Repeat step 1 to have two identical bookmarks in Recently Bookmarked folder
3. Open bookmarks sidebar
4. Open Recently Bookmarked folder
5. Left-click the last bookmarked bookmark
Actual Results:  
The above error is reported in Error Console.

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

I could think the problem is a missing check at line 964
>+if (nodesToReselect.length > 0) {
>  this._restoreSelection(nodesToReselect, aContainer);
>+}

but I cannot reproduce with the steps in comment 0, do you have better steps working in current nightly?

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

even if actually that check would be useless since _restoreSelection early returns, so looks like instead it's a undefined node in _getSelectedNodesInRange node: this._rows[i], so possibly this should use _getNodeForRow(i)...
But I need better steps to reproduce.

Comment 3

[ithinc]

I have no other reproducing steps. As you said, I cannot reproduce it any more. Maybe it is a RESOLVED WORKSFORME?
If you still want to investigate it, I suggest using 20101106 nightly.

Comment 4

[ithinc]

Unable to reproduce it in Firefox 4.0 final.