Closed Bug 610216 Opened 9 years ago Closed 9 years ago

Build bustage when SMIL is disabled

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla2.0b8

People

(Reporter: mounir, Assigned: mounir)

Details

Attachments

(1 file)

Attached patch Patch v1Splinter Review
No description provided.
Attachment #488746 - Flags: review?(dholbert)
Comment on attachment 488746 [details] [diff] [review]
Patch v1

Could you narrow the #ifdefs to *just* be around these single-lines:

     doc->GetAnimationController()->Resume(nsSMILTimeContainer::PAUSE_IMAGE);
and
     doc->GetAnimationController()->Pause(nsSMILTimeContainer::PAUSE_IMAGE);

Technically, we need the other stuff (SetImagesNeedAnimating) in non-SMIL builds, because it controls animated GIFs / PNGs, too.

r=dholbert with that.  Thanks for the fix, and sorry for busting your build! :)
Attachment #488746 - Flags: review?(dholbert) → review+
Thanks for your quick review.

Pushed:
http://hg.mozilla.org/mozilla-central/rev/c6b6c4d8b9bb
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
You need to log in before you can comment on or make changes to this bug.