Closed Bug 610266 Opened 9 years ago Closed 9 years ago

Remove Drag.isResizing

Categories

(Firefox Graveyard :: Panorama, defect, P4)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mitcho, Assigned: mitcho)

Details

(Whiteboard: [good first bug][cleanup], [qa-])

Attachments

(1 file, 2 obsolete files)

The isResizing property on Drag objects is not actually being used. Remove it.
Whiteboard: [good first bug] → [good first bug][cleanup]
Whiteboard: [good first bug][cleanup] → [good first bug][cleanup][qa-]
Attached patch Patch (obsolete) — Splinter Review
Attachment #488781 - Flags: feedback?(ian)
Comment on attachment 488781 [details] [diff] [review]
Patch

Thanks for cleaning this up!
Attachment #488781 - Flags: feedback?(ian) → feedback+
Attachment #488781 - Flags: review?(dolske)
Attachment #488781 - Flags: review?(dolske) → review+
Attachment #488781 - Flags: approval2.0?
Does it need a try run?
Attached patch Cleaned up patch, pushed to try (obsolete) — Splinter Review
I cleaned up the patch for rot, so pushed to try: 6b0c45eb1c56.
Attachment #488781 - Attachment is obsolete: true
Attachment #492220 - Flags: approval2.0?
Attachment #488781 - Flags: approval2.0?
Can we get approval on this trivial cleanup?
Attachment #492220 - Flags: approval2.0? → approval2.0+
Still waiting a bit to make sure try is completely clean... but should be, and looking good so far.
Attachment #492220 - Attachment is obsolete: true
Try was inconclusive (a lot of intermittent orange) so sent again: 6a260b5c58aa
Try passed.
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/193b661293ba
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [good first bug][cleanup][qa-] → [good first bug][cleanup], [qa-]
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.