610266 - Remove Drag.isResizing

Status: RESOLVED FIXED

(Firefox Graveyard :: Panorama, defect, P4)

Description

[Michael Yoshitaka Erlewine [:mitcho]]

The isResizing property on Drag objects is not actually being used. Remove it.

Comment 1

[Michael Yoshitaka Erlewine [:mitcho]]

Attachment: Patch

Comment 2

[Ian Gilman [:iangilman]]

Comment on attachment 488781 [details] [diff] [review]
Patch

Thanks for cleaning this up!

Comment 3

[Ian Gilman [:iangilman]]

Does it need a try run?

Comment 4

[Michael Yoshitaka Erlewine [:mitcho]]

Attachment: Cleaned up patch, pushed to try

I cleaned up the patch for rot, so pushed to try: 6b0c45eb1c56.

Comment 5

[Michael Yoshitaka Erlewine [:mitcho]]

Can we get approval on this trivial cleanup?

Comment 6

[Michael Yoshitaka Erlewine [:mitcho]]

Attachment: Patch for checkin

Still waiting a bit to make sure try is completely clean... but should be, and looking good so far.

Comment 7

[Michael Yoshitaka Erlewine [:mitcho]]

Try was inconclusive (a lot of intermittent orange) so sent again: 6a260b5c58aa

Comment 8

[Michael Yoshitaka Erlewine [:mitcho]]

Try passed.

Comment 9

[Ian Gilman [:iangilman]]

http://hg.mozilla.org/mozilla-central/rev/193b661293ba