Closed
Bug 610286
Opened 14 years ago
Closed 13 years ago
link to JSON and full logs
Categories
(Tree Management Graveyard :: OrangeFactor, defect, P1)
Tree Management Graveyard
OrangeFactor
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: k0scist, Unassigned)
References
Details
Attachments
(4 files)
5.39 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
4.71 KB,
text/plain
|
Details | |
6.11 KB,
patch
|
mcote
:
review+
|
Details | Diff | Splinter Review |
5.24 KB,
patch
|
jgriffin
:
review+
|
Details | Diff | Splinter Review |
links to the JSON summaries and full logs should be presented whereever applicable
Reporter | ||
Comment 1•14 years ago
|
||
this is probably dependent on getting the logs in the new db
Comment 2•14 years ago
|
||
we could just link the tinderbox log for the time being. I don't want to assume we will have log servers up and running anytime soon.
Updated•14 years ago
|
Priority: -- → P1
Comment 4•13 years ago
|
||
We really need two kinds of data: 1 - a high-level summary of failures, shown as a popup or something in views such as http://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=452706&startday=2011-01-03&endday=2011-01-28 This data can be retrieved from ES; see raw data at e.g., http://elasticsearch1.metrics.sjc1.mozilla.com:9200/logs/testfailures/_search?q=date:2011-02-04&size=50 2 - we should provide a link to the full log on stage (not tinderbox); stage has been upgraded and should be storing 30 days of logs now, and tinderbox will eventually be going away; we can figure out this link using an ES query
Comment 5•13 years ago
|
||
so would you advocate 2 additional links near the top of the Bug Details page: [raw data] [raw log] ? Another thing is the data from elasticsearch is not accessible via the normal internet. Should we maybe make something like this: http://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=452706&startday=2011-01-03&endday=2011-01-28&output=json ? ^ not a real link, just an idea to add a output param to the url. I think we could make that a new window/popup/tab or something like that.
Comment 6•13 years ago
|
||
We'll need links for each instance of the bug, rather than links at the top of the page, since each instance has a unique log file and potentially a unique signature. I was thinking we could put the links in the bug table. I'll add a new query to woo_server.py that will return this info; when the user clicks the 'summary' link (or whatever we're going to call it), we can get the data via the REST API, and then display it in a popup div (similar to the way tbpl presents testrun data). For the log file link, I'll just update the existing queries in woo_server.py so that they return this info in addition to other details.
Comment 7•13 years ago
|
||
This patch adds a new 'testrun' view to woo_server. With the starttime and machine name from a given orange (see bug 619505), you can use this to request all the testrun metadata that ElasticSearch has for that testrun. The output is a list of testruns with a bunch of fields as described in the bug; I'm also attaching some example output for easier review.
Attachment #510418 -
Flags: review?
Updated•13 years ago
|
Attachment #510418 -
Flags: review? → review?(jmaher)
Comment 8•13 years ago
|
||
Comment 9•13 years ago
|
||
Comment on attachment 510418 [details] [diff] [review] woo_server.py patch nice!
Attachment #510418 -
Flags: review?(jmaher) → review+
Comment 10•13 years ago
|
||
The 'logurl' backend code is now live, so the 'logurl' can now be retrieved using the new 'testrun' query, e.g.: http://brasstacks.mozilla.com/orangefactor/testrun?starttime=1297306345&machine=talos-r3-snow-050
Comment 11•13 years ago
|
||
Per mcote's request, an udpate to the serve_testrun that can work with multiple testruns so you don't need to make a separate XHR for each testrun. The resulting JSON is indexed by 'starttime|machine', e.g., { '1295484366|talos-r3-xp-037' : [ testrun list ], '1297070365|talos-r3-leopard-012' : [ testrun list ] }
Attachment #512641 -
Flags: review?(mcote)
Comment 12•13 years ago
|
||
Comment on attachment 512641 [details] [diff] [review] patch to support multiple test runs in a single request Nice. Great to see some proper Python from someone. ;) + runparams = run.split('|') + if len(runparams) == 2: + starttime = runparams[0] + machine = runparams[1] This is perfectly fine, but did you know about string.partition()? I myself only found out about it recently. You can replace those four lines with starttime, sep, machine = runparams.partition('|') if sep != '': Just thought you might be interested to know. Anyway great stuff.
Attachment #512641 -
Flags: review?(mcote) → review+
Comment 13•13 years ago
|
||
> Comment on attachment 512641 [details] [diff] [review] > patch to support multiple test runs in a single request > > > + runparams = run.split('|') > + if len(runparams) == 2: > + starttime = runparams[0] > + machine = runparams[1] > > This is perfectly fine, but did you know about string.partition()? I myself > only found out about it recently. You can replace those four lines with > > starttime, sep, machine = runparams.partition('|') > if sep != '': > > Just thought you might be interested to know. Sweet! I ran into partition once, then promptly forgot about it. Thanks for reminding me. Patch (with update) pushed as http://hg.mozilla.org/automation/orangefactor/rev/270de78edb0f
Comment 14•13 years ago
|
||
Hokay, so this patch grabs testrun data and inserts links to the full log and to the raw JSON, if available. The JSON is displayed in a sliding popup. Not much else to say here.
Attachment #513252 -
Flags: review?(jgriffin)
Comment 15•13 years ago
|
||
Comment on attachment 513252 [details] [diff] [review] Links to JSON and logs on Bug Details page Looks great! What do you think about 1em instead of 0.75em font-size for #popup p? 0.75em makes it almost unreadably small on my machine.
Attachment #513252 -
Flags: review?(jgriffin) → review+
Comment 16•13 years ago
|
||
Pushed as http://hg.mozilla.org/automation/orangefactor/rev/9449a4861480 I think that's it for this bug.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment 17•13 years ago
|
||
Oops forgot to change the font size. Increased to 1em. http://hg.mozilla.org/automation/orangefactor/rev/9b04a885a4eb
Assignee | ||
Updated•10 years ago
|
Product: Testing → Tree Management
Updated•4 years ago
|
Product: Tree Management → Tree Management Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•