Open Bug 610335 Opened 12 years ago Updated 11 years ago

Window buttons (maximize, minimize & close) are painted wrong when the menu bar is hidden w/'xpize' theming

Categories

(Firefox :: Theme, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

UNCONFIRMED

People

(Reporter: habladmedelmar, Unassigned)

References

()

Details

Attachments

(2 files, 1 obsolete file)

User-Agent:       Mozilla/5.0 (Windows NT 5.1; rv:2.0b8pre) Gecko/20101107 Firefox/4.0b8pre
Build Identifier: Mozilla/5.0 (Windows NT 5.1; rv:2.0b8pre) Gecko/20101107 Firefox/4.0b8pre

I've got installed a XP image replacement software called xpize (http://www.xpize.net/), when I hide the menu bar the window buttons are painted wrong.

A picture is worth a thousand words:
http://img149.imageshack.us/img149/9490/fxbuttons.png

Reproducible: Always

Steps to Reproduce:
1. Install xpize on windows xp
2. Hide menu bar
Actual Results:  
Window buttons are painted wrong

Expected Results:  
Normal window buttons

I'm using default theme and I've got installed xpize (xpize.net).
Blocks: 513162
Summary: Window buttons (maximize, minimize & close) are painted wrong when the menu bar is hidden → Window buttons (maximize, minimize & close) are painted wrong when the menu bar is hidden w/'xpize' theming
You might check with the authors of xpize, a number custom theming products had problems with our titlebar changes. Some like StarDock are now releasing updates to support fx 4.0.
Attached image Window buttons capture (obsolete) —
(In reply to comment #1)
> You might check with the authors of xpize, a number custom theming products had
> problems with our titlebar changes. Some like StarDock are now releasing
> updates to support fx 4.0.

browser.css adds a margin between the buttons. I don't think theme authors can do anything about that.
(In reply to comment #3)
> (In reply to comment #1)
> > You might check with the authors of xpize, a number custom theming products had
> > problems with our titlebar changes. Some like StarDock are now releasing
> > updates to support fx 4.0.
> 
> browser.css adds a margin between the buttons. I don't think theme authors can
> do anything about that.

Ah yes. I wonder if we could address this through the theme widget padding.
It is not just the margin, also paints bad the hover of the buttons when the window is disabled.

In Opera Browser the buttons look good.
Blocks: 574454
No longer blocks: 513162
Duplicate of this bug: 600315
(In reply to comment #4)
> > browser.css adds a margin between the buttons. I don't think theme authors can
> > do anything about that.
> 
> Ah yes. I wonder if we could address this through the theme widget padding.

I suspect that's what needs to happen in bug 606160.
Depends on: 606160
Attached image Win XP with theme
Reported on IRC. Using the following theme: http://browse.deviantart.com/customization/skins/windows/visualstyle/?qh=&section=&q=luna+element#/dy9y60

Looks similar to this bug.
Does the fix in bug 606160 mean that the software vendor can now fix the issue or is more work necessary on this one? (asking on behalf of the reporter)
Buttons are still wrong.

In attached image can see the buttons in 4 diferent states:

Capture 1: Window is normal and butons are wrong.
Capture 2: Window is maximized and buttons are wrong.
Capture 3: Window is maximized and buttons are right (excepting button borders).
Caputre 4: Window is normal and buttons are right (excepting button borders).

Steps:
1) Usually the window buttons are painted wrong (capture 1)
2) Double-click on bar to maximize (capture 2)
3) If I click again on window bar the buttons are repainted right (capture 3)
4) Double-click on bar to unmaximize (capture 2)
5) Click on bar and buttons repainted right (capture 4)

When buttons are painted right, if I move the mouse they are repainted wrong.
Attachment #488868 - Attachment is obsolete: true
Version: unspecified → Trunk
In fx 4.0b13 (2001-02-28), when the buttons are well painted, the actions that make them look bad again are:

- Move the mouse over the Firefox button.
- Move the mouse over the window buttons.
- Unactivate the window.
Bug is transform to https://bugzilla.mozilla.org/show_bug.cgi?id=626809
Help for fix error.
Mozilla/5.0 (Windows NT 5.1; rv:6.0a1) Gecko/20110522 Firefox/6.0a1

I use the Royale Vista II Blue theme* on Windows XP SP3 and had this bug too. This CSS in Stylish or userChrome.css makes the caption buttons look right for me:

/* make caption buttons look right with Royal Vista II VS */
#titlebar-buttonbox > .titlebar-button {
  width: 38px !important;
  margin-left: -2px !important;
  margin-right: -1px !important;
}

* http://dobee.deviantart.com/art/Royale-Vista-II-Final-55318441
Thanks... :)
(In reply to comment #13)
> Mozilla/5.0 (Windows NT 5.1; rv:6.0a1) Gecko/20110522 Firefox/6.0a1
> 
> I use the Royale Vista II Blue theme* on Windows XP SP3 and had this bug
> too. This CSS in Stylish or userChrome.css makes the caption buttons look
> right for me:
> 
> /* make caption buttons look right with Royal Vista II VS */
> #titlebar-buttonbox > .titlebar-button {
>   width: 38px !important;
>   margin-left: -2px !important;
>   margin-right: -1px !important;
> }
> 
> * http://dobee.deviantart.com/art/Royale-Vista-II-Final-55318441
You need to log in before you can comment on or make changes to this bug.