610346 - Remove nsIFormSubmitObserver interface from FormTracker

Status: RESOLVED FIXED

(Firefox :: Sync, defect, P3)

Description

[Mounir Lamouri (:mounir)]

There now are notifications from satchel. Observing form submissions shouldn't be needed anymore.

Comment 1

[Mounir Lamouri (:mounir)]

Attachment: Patch v1

I realize that this patch might be wrong if we want to keep a compatibility with Firefox 3.5 and 3.6.

Comment 2

[Philipp von Weitershausen [:philikon]]

(In reply to comment #1)
> I realize that this patch might be wrong if we want to keep a compatibility
> with Firefox 3.5 and 3.6.

We do for now.

Comment 3

[Richard Newman [:rnewman]]

We'll want to take this soon.

Comment 4

[Mounir Lamouri (:mounir)]

Comment on attachment 488841 [details] [diff] [review]
Patch v1

Do we want to take this?

Comment 5

[Richard Newman [:rnewman]]

This bitrotted a little, and there's some more code to delete (fallout from Bug 487558!), so I'll put together, test, and land an updated patch.

Thanks!

Comment 6

[Richard Newman [:rnewman]]

Attachment: Proposed patch. v2

Need to run TPS on this.

Comment 7

[Richard Newman [:rnewman]]

TPS passes. Rudimentary testing shows that search bar and Bugzilla form inputs are tracked.

Comment 8

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/bfb08e479431

Comment 9

[Mounir Lamouri (:mounir)]

Thanks for landing this Richard :)

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/bfb08e479431