Remove nsIFormSubmitObserver interface from FormTracker

RESOLVED FIXED in mozilla26

Status

Cloud Services
Firefox Sync: Backend
P3
normal
RESOLVED FIXED
8 years ago
5 years ago

People

(Reporter: mounir, Assigned: mounir)

Tracking

(Blocks: 1 bug)

unspecified
mozilla26
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa+])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

8 years ago
There now are notifications from satchel. Observing form submissions shouldn't be needed anymore.
(Assignee)

Comment 1

8 years ago
Created attachment 488841 [details] [diff] [review]
Patch v1

I realize that this patch might be wrong if we want to keep a compatibility with Firefox 3.5 and 3.6.
Assignee: nobody → mounir.lamouri
Status: NEW → ASSIGNED
(In reply to comment #1)
> I realize that this patch might be wrong if we want to keep a compatibility
> with Firefox 3.5 and 3.6.

We do for now.
Target Milestone: --- → Future
We'll want to take this soon.
Priority: -- → P3
Target Milestone: Future → ---
Blocks: 745408
(Assignee)

Comment 4

5 years ago
Comment on attachment 488841 [details] [diff] [review]
Patch v1

Do we want to take this?
Attachment #488841 - Flags: review?(rnewman)
This bitrotted a little, and there's some more code to delete (fallout from Bug 487558!), so I'll put together, test, and land an updated patch.

Thanks!
Flags: needinfo?(rnewman)
Created attachment 790501 [details] [diff] [review]
Proposed patch. v2

Need to run TPS on this.
Attachment #488841 - Attachment is obsolete: true
Attachment #488841 - Flags: review?(rnewman)
Attachment #790501 - Flags: review+
TPS passes. Rudimentary testing shows that search bar and Bugzilla form inputs are tracked.
Flags: needinfo?(rnewman)
Whiteboard: [qa+]
(Assignee)

Comment 9

5 years ago
Thanks for landing this Richard :)
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/bfb08e479431
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.