Closed
Bug 610533
Opened 14 years ago
Closed 9 years ago
crash [@ nsMsgDatabase::GetSearchResultsTable(char const*, int, nsIMdbTable**)] with virtual folder
Categories
(MailNews Core :: Database, defect)
Tracking
(thunderbird38 affected, thunderbird39 affected, thunderbird40 affected, thunderbird41 fixed)
RESOLVED
FIXED
Thunderbird 41.0
People
(Reporter: wsmwk, Assigned: rkent)
Details
(Keywords: crash)
Crash Data
Attachments
(1 file)
1.15 KB,
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
crash [@ nsMsgDatabase::GetSearchResultsTable(char const*, int, nsIMdbTable**)] bp-9d7721a6-6f9c-4019-842a-c1a542101026 v3.0.6 bp-5daa9521-c0b9-409f-ad8a-b8f402101027 v3.1.5 0 thunderbird.exe nsMsgDatabase::GetSearchResultsTable mailnews/db/msgdb/src/nsMsgDatabase.cpp:5499 1 thunderbird.exe nsMsgDatabase::GetCachedHits mailnews/db/msgdb/src/nsMsgDatabase.cpp:5512 2 thunderbird.exe nsMsgXFVirtualFolderDBView::OnNewSearch mailnews/base/src/nsMsgXFVirtualFolderDBView.cpp:455 3 thunderbird.exe nsMsgSearchSession::Search mailnews/base/search/src/nsMsgSearchSession.cpp:283 4 xpcom_core.dll NS_InvokeByIndex_P xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp:102 5 thunderbird.exe XPCWrappedNative::CallMethod js/src/xpconnect/src/xpcwrappednative.cpp:2722 6 thunderbird.exe XPC_WN_CallMethod js/src/xpconnect/src/xpcwrappednativejsops.cpp:1740 7 js3250.dll js_Invoke js/src/jsinterp.cpp:1360 8 js3250.dll js_Interpret js/src/jsops.cpp:2240 9 js3250.dll js_Invoke js/src/jsinterp.cpp:1368 10 js3250.dll js_InternalInvoke js/src/jsinterp.cpp:1423 11 js3250.dll JS_CallFunctionValue js/src/jsapi.cpp:5114 12 thunderbird.exe nsJSContext::CallEventHandler dom/base/nsJSEnvironment.cpp:2197
Comment 1•14 years ago
|
||
m_mdbStore is probably null...
Assignee: nobody → bienvenu
Status: NEW → ASSIGNED
Reporter | ||
Comment 3•14 years ago
|
||
(Note: bug# doesn't show up in socorro crash reports)
Updated•13 years ago
|
Crash Signature: [@ nsMsgDatabase::GetSearchResultsTable(char const*, int, nsIMdbTable**)]
Reporter | ||
Comment 4•12 years ago
|
||
signature for current versions is nsMsgDatabase::GetSearchResultsTable(char const*, bool, nsIMdbTable**)
Crash Signature: [@ nsMsgDatabase::GetSearchResultsTable(char const*, int, nsIMdbTable**)] → [@ nsMsgDatabase::GetSearchResultsTable(char const*, int, nsIMdbTable**)]
[@ nsMsgDatabase::GetSearchResultsTable(char const*, bool, nsIMdbTable**) ]
Reporter | ||
Comment 5•11 years ago
|
||
"Tried to open an individual email while compacting" bp-fb63445d-8812-430e-848f-248e32121203 mwu@9538 5677 nsresult nsMsgDatabase::GetSearchResultsTable(const char *searchFolderUri, bool createIfMissing, nsIMdbTable **table) hg@0 5678{ hg@0 5679 mdb_kind kindToken; hg@0 5680 mdb_count numTables; hg@0 5681 mdb_bool mustBeUnique; hg@0 5682 mdb_err err = m_mdbStore->StringToToken(GetEnv(), searchFolderUri, &kindToken);
Assignee: mozilla → nobody
Status: ASSIGNED → NEW
Reporter | ||
Comment 6•9 years ago
|
||
This still appears. Is it easy to fix? bp-5c2bbdb6-8266-4c41-a27e-992f42150417 (jeorg) bp-13cadb64-1424-4925-a6b5-53bd32150507
Flags: needinfo?(m_kato)
Summary: crash [@ nsMsgDatabase::GetSearchResultsTable(char const*, int, nsIMdbTable**)] → crash [@ nsMsgDatabase::GetSearchResultsTable(char const*, int, nsIMdbTable**)] with virtual folder
Assignee | ||
Comment 7•9 years ago
|
||
Attachment #8603417 -
Flags: review?(neil)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → rkent
Status: NEW → ASSIGNED
Comment 8•9 years ago
|
||
Comment on attachment 8603417 [details] [diff] [review] Null check nsMsgDatabase is nicely inconsistent about which error code to return when m_mdbStore is null...
Attachment #8603417 -
Flags: review?(neil) → review+
Assignee | ||
Comment 9•9 years ago
|
||
http://hg.mozilla.org/comm-central/rev/a05b10d2a3f7
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-thunderbird38:
--- → affected
status-thunderbird39:
--- → affected
status-thunderbird40:
--- → affected
status-thunderbird41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 41.0
Assignee | ||
Updated•9 years ago
|
Attachment #8603417 -
Flags: approval-comm-beta?
Attachment #8603417 -
Flags: approval-comm-aurora?
Updated•9 years ago
|
Flags: needinfo?(m_kato)
Reporter | ||
Comment 10•9 years ago
|
||
I'm not sure we should take this in beta unless there is high reward
Assignee | ||
Comment 11•9 years ago
|
||
Comment on attachment 8603417 [details] [diff] [review] Null check On Wayne's recommendation, we won't uplift this at the moment.
Attachment #8603417 -
Flags: approval-comm-beta?
Attachment #8603417 -
Flags: approval-comm-aurora?
You need to log in
before you can comment on or make changes to this bug.
Description
•