610576 - Search is not paginating

Status: VERIFIED FIXED

(Input :: General, defect, P2)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Right now, http://input.stage.mozilla.com/en-US/search/?product=mobile&version=&date_start=&date_end=&q= has an active "Older Messages" link, but no results on page 2.

Comment 1

[Fred Wenzel [:wenzel]]

Dave, this smells like a regression in our search code? I am unable to get any second page results when searching for mobile. Can you take a look, please?

Comment 2

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

http://github.com/fwenzel/reporter/commit/e63d8b9

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; I'll have to do a fair bit of regression testing, but my early tests look good so far.

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Fail; this doesn't really change pages, as the same feedback shows up.

Reopening.

Comment 5

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

http://github.com/fwenzel/reporter/commit/f7bff51

Aakash, putting this in 2.1, but you can move it to 2.0.1

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; here's a link to a screencast that proves it for now, but will eventually become unavailable: http://screencast.com/t/R9CfI0WLuW

Comment 8

[Csaba Kozák [:WonderCsabo]]

It's bad again:

page 4 and so on are the same:

http://input.mozilla.com/hu/search/?locale=hu&product=firefox&version=4.0b7&page=4

Comment 9

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

(In reply to comment #8)
> It's bad again:
> 
> page 4 and so on are the same:
> 
> http://input.mozilla.com/hu/search/?locale=hu&product=firefox&version=4.0b7&page=4

Csaba,

A resolved bug means the code is checked in.  Outside of hotfixes we deploy a week or more after the final check-ins for a cycle.  You can expect to see this change by the end of next week.

-d

Comment 10

[Csaba Kozák [:WonderCsabo]]

Okay, but this bug is *VERIFIED* FIXED, that's why I thought it should work now.

Comment 11

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

VERIFIED means that it was verified on our staging server.  See the "URL" field.

Comment 12

[Csaba Kozák [:WonderCsabo]]

Thanks and sorry for the bugspam...

Comment 13

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #12)
> Thanks and sorry for the bugspam...

No worries -- we actually shipped this, and you're experiencing bug 615844, Csaba, which will be fixed in the next push (if you'd like to double-check on staging, please check http://input.stage.mozilla.com).

Comment 14

[Csaba Kozák [:WonderCsabo]]

Ok, it seems to work on the staging server.