610701 - Help With selection doesn't stick

Status: VERIFIED FIXED

(support.mozilla.org :: Knowledge Base Software, task)

Description

[Verdi [:verdi] Best to slack me]

If you change the Help With selector to anything but Windows and Firefox 4 and then navigate to another page it will be set back to Windows and Firefox 4.

Steps to reproduce:
1. On the front page set Help with to Mac OS X and Firefox 3.5-3.6
2. Click a link to an article
3. Help with will have changed back to Windows and Firefox 4

I tested this in Minefield on OS X and Fx 3.6 on Windows 7

Comment 1

[David Tenser [:djst]]

I get the same behavior when testing this on Minefield on Ubuntu 10.10 and Firefox 3.6.12 on Ubuntu.

Comment 2

[Ricky Rosario [:rrosario, :r1cky]]

https://github.com/jsocol/kitsune/commit/47c1710c7aa6ae78a32fd2e5296a4640bfe8f9bd

Comment 3

[Rebecca Billings [:rbillings]]

Verified

Comment 4

[Rebecca Billings [:rbillings]]

Verified

Comment 5

[Rebecca Billings [:rbillings]]

There is still some strangeness with this. I verified the Help With sticking when set on /home, viewing article, and returning. However if the user goes to /mobile it doesn't stick.

1) view /home
2) change Help with to 'Maemo' > user is sent to /mobile
3) view /home

expected: Maemo
actual: default Windows

Comment 6

[Ricky Rosario [:rrosario, :r1cky]]

Yeah, I assumed that if you went to /home you wanted to a desktop OS selected for you. But it turns out that's not what is wanted. I'm working on a fix for this, thanks for reopening.

Comment 7

[Ricky Rosario [:rrosario, :r1cky]]

Should be good now:
https://github.com/jsocol/kitsune/commit/f3c74519e22c90ff6c6bccf04c58e182ea4bd2ab

Comment 8

[Rebecca Billings [:rbillings]]

Nice! Verified