610761 - "Switch to tab" can get stuck in location bar

Status: VERIFIED INVALID

(Firefox :: Address Bar, defect)

Description

[Justin Lebar (not reading bugmail)]

STR:

* Open two tabs to http://mozilla.org
* Focus the location bar.
* Type <space> <backspace>.  A list of awesomebar selections should appear.  The top one should be a switch-to-tab suggestion.
* Press <down> to select the switch-to-tab suggestion.
* Click into the main mozilla.org site

Actual results:

"Switch to tab" remains in the location bar, obscuring the site's favicon, and with it, obscuring the visual indicator as to whether the site is secure.

This doesn't seem right to me.  I'm not sure I have a concrete suggestion as to how to fix this, since the UI here is pretty complicated.  If I'd typed into the location bar and then unfocused it, I'd expect my typing to remain there.  But since I just pressed <down>, it seems like I'm not committed to that switch-to-tab action, and showing "switch-to-tab" prominently in the location bar doesn't seem right to me.

Comment 1

[Wayne Mery (:wsmwk)]

similar to Bug 594122 - Switch to tab remains in location bar when switching windows ?

Comment 2

[Justin Lebar (not reading bugmail)]

... still happens in trunk.

Comment 3

[Alice0775 White]

Confirmed 
http://hg.mozilla.org/mozilla-central/rev/6322e8f7cb2d
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:6.0a1) Gecko/20110502 Firefox/6.0a1 ID:20110502030625

[str]
1. Open more than 2 urls in new tab
2. Click Location bar to focus
3. Press down arrow key to pop up autocomplete list
4. Select "Switch To Tab" item by down arrow key, but not click/enter
5. Click content area to close the autocomplete list

[Actual]
  Stick "Switch To Tab" in Location Bar
  Favicon is blanck

[Expected]
  Status of location bar should revert.

Comment 4

[Alice0775 White]

Triggered by:
dcb347b2d3d4	Blair McBride — Bug 480350 - Show currently loaded URIs in location bar autocomplete results, allow switching to the tab. r=gavin,mak sr=mconnor

Comment 5

[Alice0775 White]

Sorry,
I am not sure whether the behavior of comment #3 is bug or intentional.

Comment 6

[Justin Lebar (not reading bugmail)]

(In reply to comment #5)
> I am not sure whether the behavior of comment #3 is bug or intentional.

Since awesomebar suggestions for things which aren't switch-to-tab go away when you focus the content area, surely leaving switch-to-tab up there is also unintentional.

Comment 7

[Dão Gottwald [:dao]]

(In reply to comment #6)
> (In reply to comment #5)
> > I am not sure whether the behavior of comment #3 is bug or intentional.
> 
> Since awesomebar suggestions for things which aren't switch-to-tab go away
> when you focus the content area,

Actually, they don't.

Comment 8

[Blair McBride [:Unfocused] (UNAVAILABLE)]

(In reply to comment #7)
> > Since awesomebar suggestions for things which aren't switch-to-tab go away
> > when you focus the content area,
> 
> Actually, they don't.

Indeed. They do go away if you hit Esc - but then, so does switch-to-tab.

The current behaviour is intentional.

Comment 9

[Justin Lebar (not reading bugmail)]

Actually, this is wfm, right?

Alice0775's STR end with:

  5. Click content area to close the autocomplete list

while comment 0's STR end with

  "Switch to tab" remains in the location bar

Comment 10

[Dão Gottwald [:dao]]

Comment 0 describes behavior that's just not a bug...

Comment 11

[Justin Lebar (not reading bugmail)]

Attachment: Screenshot

This still happens; I just needed to look more closely.  So it's definitely not WFM.  I think I didn't write the original STR clearly enough or read it closely enough, so I was looking for something which wasn't happening.  Sorry.

Is the behavior in the screenshot actually intentional?

Comment 12

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Yes. See comment 7. You've edited the contents of the urlbar - clicking away doesn't revert that normally. Switch-to-tab is no different.

Comment 13

[Caspy7]

(In reply to Blair McBride [:Unfocused] (Back from the dead. Mostly.) from comment #12)
> Yes. See comment 7. You've edited the contents of the urlbar - clicking away
> doesn't revert that normally. Switch-to-tab is no different.

I filed bug 848274, which appears to describe the same issue.  However I've not actually edited the contents of the urlbar, just hit the down key.

I'd also point out that once you've done this and hit down again you won't get any results.
And even if you add a space & some text to the end of your URL, the domain highlighting kicks back in, making the text grey and rather removing the this-url-has-been-edited aura.