Closed Bug 610781 Opened 9 years ago Closed 9 years ago

Need icons for Android-style app menu

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set

Tracking

(fennec2.0b3+)

VERIFIED FIXED
Tracking Status
fennec 2.0b3+ ---

People

(Reporter: mbrubeck, Assigned: mbrubeck)

References

Details

(Keywords: polish)

Attachments

(3 files)

+++ This bug was initially created as a clone of Bug #606565 +++

In bug 606565 we re-used existing toolbar icons for the new Android-style application menu.  We should replace these with icons that match the system style guide.

Screenshot of current placeholder icons:
https://bug606565.bugzilla.mozilla.org/attachment.cgi?id=489229

Style guide for menu icons:
http://developer.android.com/guide/practices/ui_guidelines/icon_design.html#menustructure
tracking-fennec: 2.0- → ?
Keywords: polish
Assignee: nobody → smartell
tracking-fennec: ? → 2.0b3+
Attached file android menu glyphs
Attached patch patchSplinter Review
Assignee: smartell → mbrubeck
Status: NEW → ASSIGNED
Attachment #490123 - Flags: review?(mark.finkle)
Here's a screenshot I took with the new images (plus my Full Screen add-on, which is the reason I was screenshotting):
https://addons.mozilla.org/img/uploads/previews/full/50/50896.png
awesome!

Can we turn off the internal drop shadows? I added a top shadow effect on the actual graphic and it should match the native orange pressed states.
But why orange?
native Android look, and our blue doesn't work well underneath the default grey style for the icons when active.
Great. Another thing that will break consistency with my HTC Desire.

I hope 4.1 will arrive soon.
(In reply to comment #5)
> Can we turn off the internal drop shadows? I added a top shadow effect on the
> actual graphic and it should match the native orange pressed states.

Done.  (I actually did this after taking the screenshot, but before posting the patch.)

(In reply to comment #6)
> But why orange?

Orange is the highlight color for the menu in the stock Android theme.  We can file a followup bug to use colors/textures from the Android system theme.
(In reply to comment #9)
> Orange is the highlight color for the menu in the stock Android theme.  We can
> file a followup bug to use colors/textures from the Android system theme.

That would be great! But would it make into 4.0?
(In reply to comment #8)
> Great. Another thing that will break consistency with my HTC Desire.
> 
> I hope 4.1 will arrive soon.

Perhaps before then we could make a simple Fennec theme add-on that changes some of the current colors and images to fit in with HTC Sense.
(In reply to comment #11)

> Perhaps before then we could make a simple Fennec theme add-on that changes
> some of the current colors and images to fit in with HTC Sense.

+1
+1? No, +infinite!
Comment on attachment 490123 [details] [diff] [review]
patch

appmenu-prefs-hdpi.png -> appmenu-preferences-hdpi.png

We might need to move these to CSS as well, when we reuse the menu for other platforms. We can cross that bridge later.
Attachment #490123 - Flags: review?(mark.finkle) → review+
Pushed, with the filename fix: http://hg.mozilla.org/mobile-browser/rev/c6ab189d5d74
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
verified FIXED on build:

Mozilla/5.0 (Android; Linux armv71; rv:2.0b8pre) Gecko/20101115 Namoroka/4.0b8pre Fennec/4.0b3pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.