610783 - Animated transitions for titlebar and Android menu

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect)

Description

[Matt Brubeck (:mbrubeck)]

When the titlebar or app menu appear and disappear, they should slide smoothly onto (or off of) the screen.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

We can look at partial transitions. Those might have better performance characteristics. Start at halfway through the transition and continue to completion instead of transitioning fully.

The eye still sees motion, but we might look better and be less jumpy.

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: WIP v0.1

I was working on a refactor for Popups/Panel/Dialogs that will allow this kind of things to be integrated

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Wow. This patch is bigger than the original intent :)

Can we do a simple animation of the Android menu?

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

No need to track this. We'll get it landed when it's ready

Comment 5

[Wesley Johnston (:wesj)]

Attachment: Patch v1

This is a very simple solution that animates just the menubar and adds a little "HideAnimator" class for us to use.

Comment 6

[Wesley Johnston (:wesj)]

Attachment: Patch v2

Slightly updated. Animates showing and hiding (some) dialogs now as well.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 552690 [details] [diff] [review]
Patch v2

Didn't have time yet for a full review, but nice patch overall. I'd rename HideAnimator since it does more than hide. Maybe WidgetAnimator?

The more animations we add in this patch, the more we need buy in from UX (including screenshots and such) before we land it. Just food for thought :)

Comment 8

[Wesley Johnston (:wesj)]

Yeah, I'm ok with limiting this just to the android menu for now. There is a rather old build with this at:

http://dl.dropbox.com/u/72157/fennec-animations.apk

madhava, can someone on ux look at that? The android menu should animate when appearing, as well as alert/prompt/etc. dialogs.

Comment 9

[BMO Automation]

Closing all opened bug in a graveyard component