Closed Bug 610783 Opened 9 years ago Closed 4 months ago

Animated transitions for titlebar and Android menu

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set

Tracking

(fennec-)

RESOLVED WONTFIX
Tracking Status
fennec - ---

People

(Reporter: mbrubeck, Unassigned)

References

Details

(Keywords: polish)

Attachments

(2 files, 1 obsolete file)

When the titlebar or app menu appear and disappear, they should slide smoothly onto (or off of) the screen.
tracking-fennec: --- → ?
Keywords: polish
tracking-fennec: ? → 2.0-
We can look at partial transitions. Those might have better performance characteristics. Start at halfway through the transition and continue to completion instead of transitioning fully.

The eye still sees motion, but we might look better and be less jumpy.
Whiteboard: [fennec-4.1?]
Assignee: nobody → wjohnston
tracking-fennec: - → 6+
Whiteboard: [fennec-4.1?]
Attached patch WIP v0.1Splinter Review
I was working on a refactor for Popups/Panel/Dialogs that will allow this kind of things to be integrated
Wow. This patch is bigger than the original intent :)

Can we do a simple animation of the Android menu?
No need to track this. We'll get it landed when it's ready
tracking-fennec: 6+ → -
Attached patch Patch v1 (obsolete) — Splinter Review
This is a very simple solution that animates just the menubar and adds a little "HideAnimator" class for us to use.
Attachment #551050 - Flags: review?(mark.finkle)
Attached patch Patch v2Splinter Review
Slightly updated. Animates showing and hiding (some) dialogs now as well.
Attachment #551050 - Attachment is obsolete: true
Attachment #552690 - Flags: review?(mark.finkle)
Attachment #551050 - Flags: review?(mark.finkle)
Comment on attachment 552690 [details] [diff] [review]
Patch v2

Didn't have time yet for a full review, but nice patch overall. I'd rename HideAnimator since it does more than hide. Maybe WidgetAnimator?

The more animations we add in this patch, the more we need buy in from UX (including screenshots and such) before we land it. Just food for thought :)
Yeah, I'm ok with limiting this just to the android menu for now. There is a rather old build with this at:

http://dl.dropbox.com/u/72157/fennec-animations.apk

madhava, can someone on ux look at that? The android menu should animate when appearing, as well as alert/prompt/etc. dialogs.
Attachment #552690 - Flags: review?(mark.finkle)
Assignee: wjohnston → nobody
Closing all opened bug in a graveyard component
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.