610797 - Need ability to disable add-on compatibility check in Mozmill

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[u279076]

As a result of bug 610743 (unexpected incompatible Feedback add-on), we cannot run automation for updates.  The reason is our automation does not take into affect the Check Compatibility dialog.

This is a bug to set the prefs to disable this dialog on update testruns.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch v1

This patch is kinda really important if add-ons bundled to the application aren't compatible with the next version.

Comment 2

[cmtalbert]

Comment on attachment 489303 [details] [diff] [review]
Patch v1

We need to do better than this for 2.0, but for 1.5.x this is fine.  This should be  upstreamed differently -- i.e. there should be a mechanism to set the default prefs for mozmill and that should be used rather than hard coding all prefs so that all applications do not have to use the same prefs.  Less important for this specific pref, but it will be more important going forward.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Landed as:

https://github.com/mozautomation/mozmill/commit/43b7ceb7cf2a98810f83f7b5d16b193dfbfe6e4d (master)

https://github.com/mozautomation/mozmill/commit/0305bd4f0361cde6e156c9040e05d4726416adec (hotfix-1.5.1)