610807 - Developers without the "listed" flag are treated as users unrelated to their add-on

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P2)

Description

[Jorge Villalobos [:jorgev] (he/him)]

It looks like there are a number of features on AMO that rely on the developer / owner of an add-on to have the "listed" property set. This property should be for public display purposes only, but it appears to be having a negative effect on other areas:

1) The developer doesn't receive editor review emails.
2) The developer can review their own add-ons.
3) The developer doesn't appear in the editor review pages.

There could be more of these. It looks like there's a function somewhere that is intended to return all developers for an add-on, and in reality only returns the listed ones.

Comment 1

[Justin Scott [:fligtar]]

This is a big problem right now -- lots of developers aren't receiving review emails and don't realize their add-ons have been rejected.

Comment 2

[Wil Clouser [:clouserw]]

Can you give me a specific example?  What makes you think this is related to the listed flag?

Comment 3

[Jorge Villalobos [:jorgev] (he/him)]

Points 2 and 3 are easily testable. Point 1 was tested by Andrew. I don't recall the exact add-on, but maybe he can.

It was a case were a nomination was rejected and resubmitted over and over with no reply from the developer. Andrew tried changing the flag before rejecting the add-on again, and got a response within minutes.

Comment 4

[Jorge Villalobos [:jorgev] (he/him)]

FYI, fixing bug 585768 should get rid of (1).

Comment 5

[Andrew Williamson [:eviljeff]]

(In reply to comment #3)
> Points 2 and 3 are easily testable. Point 1 was tested by Andrew. I don't
> recall the exact add-on, but maybe he can.

I test I uploaded a new addon (it was a random search plugin I was testing that I modified) https://addons.mozilla.org/en-US/developers/addon/edit/252560

I first suspected it was happing after an addon (extension - I don't recall which) I'd repeatedly rejected was fixed within less than an hour after I edited it to make a developer visible.

Comment 6

[Wil Clouser [:clouserw]]

Alright, I can confirm all three of these.  #2 is new, #1 and #3 are old - we haven't redone the editor tools yet.  Chenb can fix them in the editor tools in the next milestone if they are important enough to do ahead of the rewrite.

Comment 7

[Barry Chen]

Attachment: small patch to select all, not only listed, authors for reviews

Comment 8

[Wil Clouser [:clouserw]]

Is this something we can do with the bindOnly() or other bind functions?  I've never seen anyone mess with the HABTM stuff directly and it makes me nervous :)

Comment 9

[Barry Chen]

The bind methods only allow someone to specify the models to bind, but not the options to bind with.  The Addon model does not bind with User or perform find() again in that action, so editing the conditions option shouldn't be an issue as it is.

The main concern is that if the conditions option ever change to include more conditions, this patch will drop those additional conditions along with listed.  But I definitely don't want to edit the Addon model because other parts of the app that rely on it.  I could cook up something for bindOnly to accept binding options, but that will introduce more possibilities for bugs. :-P

Comment 10

[Wil Clouser [:clouserw]]

Heh, ok.  Well, commit this and let us know so people can check it out.

Comment 11

[Barry Chen]

Committed @ r78400

Comment 12

[Jorge Villalobos [:jorgev] (he/him)]

Reclassifying editor bugs and changing to a new whiteboard flag. Spam, spam, spam, spam...