610820 - Larger favicons for extension will not align vertically in addons manager

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Tony Chung [:tchung]]

Attachment: Indented Extension screenshot

it seems if the favicon is slightly larger than the other default ones (not square), then it will show an indent of the extension entry in addons manager

* See screenshot

REpro:
1) install android nightly: Mozilla/5.0 (Android; Linux armv71; rv:2.0b8pre) Gecko/20101109 Firefox/4.0b8pre Fennec/4.0b3pre	
2) install Reading list addon
3) open prefs > addons, and verify extension is indented

Expected:
- vertically aligned

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

We should set the max-width / max-height of the images to 32px. It will disort the wide images, but not create the weird indents.

Comment 2

[Matt Brubeck (:mbrubeck)]

Attachment: patch

Simple fix.  (I'm also uploading a new version of Reading List that has the correct icon size.)

Comment 3

[Matt Brubeck (:mbrubeck)]

http://hg.mozilla.org/mobile-browser/rev/65a51b9755d1

Comment 4

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (Maemo; Linux armv71; rv:2.0b8pre) Gecko/20101111 Namoroka/4.0b8pre Fennec/4.0b3pre

and

Mozilla/5.0 (Android; Linux armv71; rv:2.0b8pre) Gecko/20101111 Namoroka/4.0b8pre Fennec/4.0b3pre