Closed Bug 610845 Opened 9 years ago Closed 9 years ago

Make Add-on Builder Helper Addon work properly on Firefox 4.0b7 and 4.0b8pre

Categories

(Mozilla Labs Graveyard :: FlightDeck, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: avarma, Assigned: avarma)

References

Details

This will be a tracking bug for everything blocking ABH compatibility for FF4.0b6 and FF4.0b8pre.
Depends on: 598778, 586277, 609226
I've fixed a bunch of bugs today in the ABH repo, which is now at version 0.0.13:

https://github.com/toolness/addons-builder-helper/commit/5a35f6fb6eb5263d363186adbfaea678916215f7

I've also rebuilt the ABH using the Jetpack SDK at this revision:

https://github.com/mozilla/addon-sdk/commit/1ff4a78f2d774c01cc8077b866bea8dad8d0155c

This version of ABH is available here:

https://secure.toolness.com/xpi/addons-builder-helper.html

I've tested this out on 4.0b6 and one of the recent nightlies, and it seems to work okay; in fact, I can't seem to reproduce bug 586277, bug 598778, or bug 609226 with it at all. Please try it out and let me know if you have problems.

Note that if you want to try out this add-on with 4.0b8pre, you'll have to set the "extensions.checkCompatibility.4.0b" preference to false. I didn't want to hack the install.rdf generated by the Add-on SDK because the SDK is still technically not compatible with 4.0b8pre, even though this particular extension ought to work with it.
Assignee: nobody → avarma
Status: NEW → ASSIGNED
Confirmed works on latest nightly and production Flightdeck. Thanks for fixing this!

It would be great to get a test written that flexes basic scenarios with the Firefox+ABH+AOB combination. We couldn't really run it in continuous integration (yet), but maybe something in the SDK that we devs can run manually?
Another thought: Should the ABH move into the Flightdeck master repo, so all project admins can handle pull requests and whatnot?
OS: Mac OS X → All
Hardware: x86 → All
Actually, the integration points between ABH and FlightDeck are intentionally pretty well-documented and defined, so we don't need FlightDeck around to test it. I can try making some tests in ABH that exercise things, and if we add ABH to the Jetpack SDK repo, we can actually have them double as tests that exercise the loading/unloading functionality of jetpack-built addons at a very high level.
I've just added a pretty nifty test that tests out a bunch of things about the XPIs that the sdk generates by using the restartless addons manager in firefox 4:

https://github.com/toolness/addons-builder-helper/commit/69bd83a09a8a9e99cde5dd60d33a0694c381b48c

I'd really like to move this into the SDK, as it exercises a bunch of the code in components/harness.js that isn't otherwise exercised.
Awesome, thanks for making the test. We should get the AOBH into the SDK repo asap then.

Also, I made a compatibility matrix, since I needed a sure-fire working scenario for a workshop I'm doing at FOSSASIA tomorrow. It's concerning to say the least.

https://spreadsheets.google.com/ccc?key=0AjIcGNW1bFV5dHczYXJUejg0ZnQtZUMzLUh1TXp1dlE&hl=en&authkey=CNaiqacK
Dietrich, were you testing on flightdeck.zalewa.info when generating the matrix?
Can we assume it is fixed?
(In reply to comment #7)
> Dietrich, were you testing on flightdeck.zalewa.info when generating the
> matrix?

No, just the public one that we point everyone at. I only included Atul's unreleased AOBH in a desperate attempt to put some green on some version of Firefox 4.
Okay, I'm marking this bug as fixed... please reopen if the addon gets busted again.

Note, though, that this new ABH isn't on AMO, it's only currently hosted on my personal server, and is available on github... Piotr and/or Daniel, can you make a bug for uploading it to AMO and assign it to me shortly before the latest version of flightdeck needs to go live?
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
(In reply to comment #10)
> Note, though, that this new ABH isn't on AMO, it's only currently hosted on my
> personal server, and is available on github... Piotr and/or Daniel, can you
> make a bug for uploading it to AMO and assign it to me shortly before the
> latest version of flightdeck needs to go live?

Is there any reason not to push the new version of ABH to AMO immediately?  Does the new version of ABH not work with the released version of AOB (and if not, couldn't it be made to work with both versions)?

If the new version of ABH were to get pushed to AMO, then it would get more testing, and it would be easier for AOB testers to use it when testing new versions of AOB.
Yeah I guess it can go up at any time, I think Atul just wants a revolving bug to keep track of it.
The version used by the add-ons builder does not work. I am continually asked to install it on 'Test' even though it is installed (0.0.12).

0.0.13 at https://secure.toolness.com/xpi/addons-builder-helper.html is not compatible with 4.0b8pre.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
The Builder is completely broken because of this. Am I the only one seeing this?

And the latest API core being offered is 0.7, while we are at 0.9.
Myk has informed me about what is going on and about bug 604641.
Any Builder issues should be resolved on b7 with the upcoming push of 1.0a6. The working edge build is here if you'd like to test it: http://flightdeck.zalewa.info
Depends on: 604641
Blocks: 611734
to install 0.0.13 on 4.0b8pre one has to edit the about:config

set check compatibility to false
extensions.checkCompatibility.4.0b;false

to test on "unstable" and staging servers please add following to trusted origins:

extensions.addonBuilderHelper.trustedOrigins;http://flightdeck.zalewa.info,https://builder-addons.allizom.org
Changing this to depend on 613341 instead of 604641 since the only tests failing on 4.0b7 are in the tabs module, which ABH doesn't use.

Also changing the title of this bug to mention 4.0b7 instead of 4.0b6.
Depends on: 613341
No longer depends on: 604641
Summary: Make Add-on Builder Helper Addon work properly on Firefox 4.0b6 and 4.0b8pre → Make Add-on Builder Helper Addon work properly on Firefox 4.0b7 and 4.0b8pre
Ok, this should be fixed now, and the latest ABH beta should be compatible with both 4.0b7 and 4.0b8pre:

https://secure.toolness.com/xpi/addons-builder-helper.html
Status: REOPENED → RESOLVED
Closed: 9 years ago9 years ago
Resolution: --- → FIXED
I tried the following combinations with ABH 0.15:

FD:
* production
* zalewa.info

(allizom staging is 404 now?!)

Firefox:
* Latest nightly
* Beta 7

Flightdeck didn't detect the ABH on any combination of the above. The error I'm seeing in the error console is: "error: addon-config.json doesn't exist or is malformed"
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
oops, also I tested on Linux, and with a new profile.
0.0.15 is working fine for me on fresh Minefield 4.0b8pre on Linux.
I'm using an Add-on depending on Addon-kit 0.9 on http://flightdeck.zalewa.info/

By working I mean - I receive a confirmation after hitting Test button
Wow, I am ridiculous. Fixed the malformed JSON error, can you try 0.0.17? It's here:

https://secure.toolness.com/xpi/addons-builder-helper.html
Dietrich confirmed that it works now--marking as fixed, but reopen if needed!
Status: REOPENED → RESOLVED
Closed: 9 years ago9 years ago
Resolution: --- → FIXED
Product: Mozilla Labs → Mozilla Labs Graveyard
You need to log in before you can comment on or make changes to this bug.