61093 - Mail crashes on opening at any time

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P1)

Description

[John Hayward-Warburton]

From Bugzilla Helper:
User-Agent: Mozilla/4.75 [en] (X11; U; Linux 2.4.0-test10 i686)
BuildID:    2000112308

Mail (either selected from Tasks -> Mail, or started with mozilla -mail) crashes
the whole browser on startup (see browser-generated trace, below).


Reproducible: Always
Steps to Reproduce:
1.Start mail window
2.
3.

Actual Results:  Errors (see below) and segfault.

Expected Results:  Worked normally.

XML Error in file 'chrome://messenger/content/mailWindowOverlay.xul', Line
Number: 381, Col Number: 25, Description: undefined entity
Source Line:                   value="&openLinkCmd.label;"
Warning add child failed!!
*** Failed to load overlay chrome://messenger/content/mailWindowOverlay.xul
Warning add child failed!!
start message pane with: http://www.mozilla.org/mailnews/start.html
In SortColumn
SetupCommandUpdateHandlers
************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "[JavaScript Error: "IsGetNewMessagesEnabled is not defined"
{file: "chrome://messenger/content/mail3PaneWindowCommands.js" line: 300}]
[nsIController::isCommandEnabled]"  nsresult: "0x80570021
(NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame ::
chrome://global/content/globalOverlay.js :: goUpdateCommand :: line 57"  data:
yes]
************************************************************
An error occurred updating the cmd_getNewMessages command
************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "[JavaScript Error: "IsGetNextNMessagesEnabled is not defined"
{file: "chrome://messenger/content/mail3PaneWindowCommands.js" line: 302}]
[nsIController::isCommandEnabled]"  nsresult: "0x80570021
(NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame ::
chrome://global/content/globalOverlay.js :: goUpdateCommand :: line 57"  data:
yes]
************************************************************
An error occurred updating the cmd_getNextNMessages command
************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "[JavaScript Error: "IsEmptyTrashEnabled is not defined" {file:
"chrome://messenger/content/mail3PaneWindowCommands.js" line: 304}]
[nsIController::isCommandEnabled]"  nsresult: "0x80570021
(NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame ::
chrome://global/content/globalOverlay.js :: goUpdateCommand :: line 57"  data:
yes]
************************************************************
An error occurred updating the cmd_emptyTrash command
************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "[JavaScript Error: "IsCompactFolderEnabled is not defined" {file:
"chrome://messenger/content/mail3PaneWindowCommands.js" line: 306}]
[nsIController::isCommandEnabled]"  nsresult: "0x80570021
(NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame ::
chrome://global/content/globalOverlay.js :: goUpdateCommand :: line 57"  data:
yes]
************************************************************
An error occurred updating the cmd_compactFolder command
/usr/local/mozilla/run-mozilla.sh: line 72: 20220 Segmentation fault      $prog
${1+"$@"}

Comment 1

[Peter "jag" Annema]

*** Bug 61127 has been marked as a duplicate of this bug. ***

Comment 2

[Peter "jag" Annema]

*** Bug 61114 has been marked as a duplicate of this bug. ***

Comment 3

[Peter "jag" Annema]

Heh, this one slipped by us...

Mail/news is using navigator.dtd (Bad! Evil!) and we need to fix that...
This makes painfully clear why :-/

So, could you test to see if mail/news uses any other entities in navigator.dtd,
and if not, replace its reference with your commands one (for the time being)
and otherwise add it?

Comment 4

[Peter "jag" Annema]

http://lxr.mozilla.org/seamonkey/search?string=navigator.dtd

mailWindowOverlay.xul, messenger.xul and hiddenWindow.xul pull in navigator.dtd.

hiddenWindow.xul has navigatorOverlay.xul (and nothing much else), so that one's
okay. It looks like you'll just need to add contentAreaCommands.dtd to
mailWindowOverlay.xul.

messenger.xul pulls in mailWindowOverlay.xul and it looks like it doesn't need
contentAreaCommands.dtd. It also seems the only reason it has navigator.dtd is
because of &titleModifier.label; and friends. Time to create some new dtds :-)

Comment 5

[Doron Rosenberg (IBM)]

seeing on win98 as well, tis a blocker. Status is: [blake should be punished]

Comment 6

[Blake Ross]

I couldn't find any other need for navigator.dtd in mailWindowOverlay.xul, and 
replacing it with contentAreaCommands.dtd seemed to fix everything on my debug 
build (I still don't see it on my optimized build; I don't know why).  So I 
checked in to replace it.  Downgrading this but leaving it open until someone 
can confirm in the next set of nightlies that mail is okay.

Comment 7

[Blake Ross]

cls verified the fix.

Comment 8

[Andreas Franke (gone)]

I think this is fixed now. I had the problem on PC/Linux with the 11/24 nightly,
and it's fixed with the 11/26 build. Marking verified.

I tested it with the following steps:
1. Startup mozilla, and load http://www.mozilla.org/community.html
2. Click on the "netscape.public.mozilla.announce" link.

The 11/24 build crashed with the error output from this bug's orig. description,
the 11/26 build brings up the mail/news window quite fine.

Comment 9

[John Hayward-Warburton]

Looks good on Linux build 2000112606, X-4.0.1.