Build with --enable-system-cairo broken

RESOLVED INVALID

Status

()

Core
Graphics
RESOLVED INVALID
8 years ago
8 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

8 years ago
Created attachment 489428 [details] [diff] [review]
Octoploid's patch from bug 594322 comment #12

This is a followup bug for bugs 594322 and bug 595805. The reason why bug 595805 was filed has not been fixed, and is now a problem: you can't assume system cairo 1.10 has SKIA enabled. And seeing the state of SKIA and how cairo builds against it (statically, and ./configure looking for the lib in SKIA build directory), I don't see this happening any time soon on most linux distributions.

Thus Octoploid's patch from bug 594322 comment 12 is still required.
Attachment #489428 - Flags: review?(roc)
(Assignee)

Comment 1

8 years ago
Comment on attachment 489428 [details] [diff] [review]
Octoploid's patch from bug 594322 comment #12

Ghah and now I realize I was building against system cairo 1.8 and that while this (kind of) works for 1.8, it doesn't for 1.10.
Attachment #489428 - Flags: review?(roc)
(Assignee)

Comment 2

8 years ago
Created attachment 489431 [details] [diff] [review]
Modified patch

This version should work. cairo-features.h doesn't contain CAIRO_HAS_SKIA_SURFACE with SKIA support is disabled, and does when it is enabled.
Attachment #489428 - Attachment is obsolete: true
Attachment #489431 - Flags: review?(roc)
I'm confused -- the CAIRO_SURFACE_TYPE_SKIA enum value is unconditionally defined as part of the surface type enum in cairo.h, it doesn't have anything to do with whether the surface is actually enabled or not.
(FWIW, the similar-looking D2D check is there because D2D isn't in upstream cairo)
Comment on attachment 489431 [details] [diff] [review]
Modified patch

What Vlad said.
Attachment #489431 - Flags: review?(roc) → review-
(Assignee)

Comment 6

8 years ago
I probably got confused by the fact I'm trying to build against cairo 1.8, which just works except for this CAIRO_HAS_SKIA_SURFACE value.
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.