Refactor AtomWB to expose some core functionality to MMgc

RESOLVED FIXED in Q3 11 - Serrano

Status

Tamarin
Garbage Collection (mmGC)
P3
normal
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Lars T Hansen, Assigned: Lars T Hansen)

Tracking

(Blocks: 1 bug)

unspecified
Q3 11 - Serrano
Bug Flags:
flashplayer-bug -

Details

(Whiteboard: has-patch)

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
Created attachment 489474 [details] [diff] [review]
Patch

The exact tracing work needs to be able to know a little bit about AtomWB, just like it knows a little bit about Atom.  Since the AtomWB methods are closely tied to eg AvmCore::atomWriteBarrier{_ctor,_dtor,} it's a major pain to move AtomWB outright into MMgc.  Instead, we can create a base class in MMgc that has the necessary functionality and from can be extended by AtomWB.
Attachment #489474 - Flags: review?(treilly)

Updated

7 years ago
Attachment #489474 - Flags: review?(treilly) → review+

Comment 1

7 years ago
Why not just move atomWriteBarrier* from AvmCore into MMgc? (And provide inline wrappers in AvmCore)
(Assignee)

Comment 2

7 years ago
That was the other possibility that was discussed.  The subclassing seemed like much the smaller change and was attractive for that reason.
(Assignee)

Comment 3

7 years ago
tamarin-redux changeset:   5538:9f9af02685c4
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED

Updated

7 years ago
Flags: flashplayer-bug-
You need to log in before you can comment on or make changes to this bug.