Closed
Bug 610994
Opened 14 years ago
Closed 14 years ago
Talos depends on cruft in package
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(fennec2.0b3+)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
fennec | 2.0b3+ | --- |
People
(Reporter: mfinkle, Assigned: jmaher)
References
Details
Attachments
(1 file, 3 obsolete files)
774 bytes,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
Fennec doesn't yet support a package manifest. We end up with some unwanted cruft in our final packages. This patch just removes the remaining cruft.
Attachment #489480 -
Flags: review?(blassey.bugs)
Updated•14 years ago
|
Attachment #489480 -
Flags: review?(blassey.bugs) → review+
Reporter | ||
Comment 1•14 years ago
|
||
pushed: http://hg.mozilla.org/mobile-browser/rev/7ebc6e7d7f0a need to watch that talos stays green
Reporter | ||
Updated•14 years ago
|
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 2•14 years ago
|
||
talos did not stay green, backout: http://hg.mozilla.org/mobile-browser/rev/c4f2b99d9377
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Reporter | ||
Comment 3•14 years ago
|
||
Changing this bug to figure out why talos needs this crap in the package.
Summary: Remove more cruft from packaging → Talos depends on cruft in package
Reporter | ||
Comment 4•14 years ago
|
||
All pageloader related talos tests went orange
Comment 5•14 years ago
|
||
For Firefox, at least, Talos should be installing the pageloader before running. Maybe this isn't happening for Mobile Talos?
Assignee | ||
Comment 6•14 years ago
|
||
hmm, interesting...on maemo, I am not sure if we install the pageloader stuff. For android, we are installing it in the profile.
Comment 8•14 years ago
|
||
on maemo, we have a tarball that contains all tools to run tests. Would using the same pageloader and talos archives that we use for desktop runs solve this problem?
Assignee | ||
Comment 9•14 years ago
|
||
removed tp-cmdline.manifest. That was the cause.
Assignee: nobody → jmaher
Attachment #489480 -
Attachment is obsolete: true
Attachment #490744 -
Flags: review?(mark.finkle)
Reporter | ||
Comment 10•14 years ago
|
||
Comment on attachment 490744 [details] [diff] [review] patch 2 >+ components/tp-cmdline.js \ >+ components/tp-cmdline.manifest \ >+ components/reftest-cmdline.js \ components/tp-cmdline* \ components/reftest-cmdline* \ Would probably be better. reftest-cmdline.manifest was still being included too. Crap, I can't believe I missed that the first time! r+ with that nit. I can land.
Attachment #490744 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 11•14 years ago
|
||
fixed nit: tp-cmdline* \ reftest-cmdline* \ did quick sanity check on build, package, unpack and search for files followed by quick launch.
Attachment #490744 -
Attachment is obsolete: true
Attachment #490798 -
Flags: review+
Reporter | ||
Comment 12•14 years ago
|
||
pushed: http://hg.mozilla.org/mobile-browser/rev/fcd90cf61114
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 13•14 years ago
|
||
Still made talos go orange. Backing out: http://hg.mozilla.org/mobile-browser/rev/bc067ab4e8b1
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 14•14 years ago
|
||
updated for httpd.* to remove httpd.manifest
Attachment #490798 -
Attachment is obsolete: true
Attachment #490886 -
Flags: review?(mark.finkle)
Reporter | ||
Updated•14 years ago
|
Attachment #490886 -
Flags: review?(mark.finkle) → review+
Reporter | ||
Comment 15•14 years ago
|
||
pushed again since bug 612579 landed): http://hg.mozilla.org/mobile-browser/rev/4194dd82c1e8
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED
Comment 16•13 years ago
|
||
How can I verify this ?
You need to log in
before you can comment on or make changes to this bug.
Description
•