Closed Bug 610994 Opened 14 years ago Closed 14 years ago

Talos depends on cruft in package

Categories

(Firefox for Android Graveyard :: General, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(fennec2.0b3+)

RESOLVED FIXED
Tracking Status
fennec 2.0b3+ ---

People

(Reporter: mfinkle, Assigned: jmaher)

References

Details

Attachments

(1 file, 3 obsolete files)

Attached patch patch (obsolete) — Splinter Review
Fennec doesn't yet support a package manifest. We end up with some unwanted cruft in our final packages. This patch just removes the remaining cruft.
Attachment #489480 - Flags: review?(blassey.bugs)
Attachment #489480 - Flags: review?(blassey.bugs) → review+
pushed:
http://hg.mozilla.org/mobile-browser/rev/7ebc6e7d7f0a

need to watch that talos stays green
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
talos did not stay green, backout:
http://hg.mozilla.org/mobile-browser/rev/c4f2b99d9377
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Changing this bug to figure out why talos needs this crap in the package.
Summary: Remove more cruft from packaging → Talos depends on cruft in package
All pageloader related talos tests went orange
For Firefox, at least, Talos should be installing the pageloader before running. Maybe this isn't happening for Mobile Talos?
hmm, interesting...on maemo, I am not sure if we install the pageloader stuff.  For android, we are installing it in the profile.
this bug is blocking our p
Blocks: 575751
tracking-fennec: --- → 2.0b3+
on maemo, we have a tarball that contains all tools to run tests.  Would using the same pageloader and talos archives that we use for desktop runs solve this problem?
Attached patch patch 2 (obsolete) — Splinter Review
removed tp-cmdline.manifest.  That was the cause.
Assignee: nobody → jmaher
Attachment #489480 - Attachment is obsolete: true
Attachment #490744 - Flags: review?(mark.finkle)
Comment on attachment 490744 [details] [diff] [review]
patch 2


>+	components/tp-cmdline.js \
>+	components/tp-cmdline.manifest \
>+	components/reftest-cmdline.js \

	components/tp-cmdline* \
	components/reftest-cmdline* \

Would probably be better. reftest-cmdline.manifest was still being included too.

Crap, I can't believe I missed that the first time!

r+ with that nit. I can land.
Attachment #490744 - Flags: review?(mark.finkle) → review+
Attached patch patch 3 (obsolete) — Splinter Review
fixed nit:
tp-cmdline* \
reftest-cmdline* \

did quick sanity check on build, package, unpack and search for files followed by quick launch.
Attachment #490744 - Attachment is obsolete: true
Attachment #490798 - Flags: review+
pushed:
http://hg.mozilla.org/mobile-browser/rev/fcd90cf61114
Status: REOPENED → RESOLVED
Closed: 14 years ago14 years ago
Resolution: --- → FIXED
Still made talos go orange. Backing out:
http://hg.mozilla.org/mobile-browser/rev/bc067ab4e8b1
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Depends on: 612579
Depends on: 612582
Attached patch patch 4Splinter Review
updated for httpd.* to remove httpd.manifest
Attachment #490798 - Attachment is obsolete: true
Attachment #490886 - Flags: review?(mark.finkle)
Attachment #490886 - Flags: review?(mark.finkle) → review+
pushed again since bug 612579 landed):
http://hg.mozilla.org/mobile-browser/rev/4194dd82c1e8
Status: REOPENED → RESOLVED
Closed: 14 years ago14 years ago
Resolution: --- → FIXED
How can I verify this ?
You need to log in before you can comment on or make changes to this bug.