Closed Bug 611044 Opened 14 years ago Closed 13 years ago

Add compartment checks before and after debug hook calls

Categories

(Core :: JavaScript Engine, defect)

Other Branch
defect
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: jorendorff, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached patch v1Splinter Review
Inspired by bug 610973, though they probably wouldn't have caught that bug any earlier. Anyway, there's no point in not having these assertions.
Attachment #489527 - Flags: review?(mrbkap)
Review ping.

Note that this patch isn't trying to pin the JSDBGAPI to down any kind of scary compartmentally strict contracts that might assert all over the place. Rather, these assertions are enforcing some very basic, obvious aspects of the contracts of the JSDBGAPI *callbacks*; if they trip, it's definitely a serious bug.
Comment on attachment 489527 [details] [diff] [review]
v1

Have you tried this patch with Firebug on? It might be worth doing at least a very basic smoketest to make sure this isn't going to entirely break debug builds with Firebug enabled.

Sorry for the delay.
Attachment #489527 - Flags: review?(mrbkap) → review+
Assignee: general → nobody
Component: JavaScript Engine → JavaScript Debugging APIs
QA Contact: general → jsd
Blocks: 636907
->WONTFIX.

I don't want to risk breaking something and wasting hours of somebody's time. JSD2's callbacks will just be JS functions, so we'll get the benefit of the existing assertions (in CallJSNative and all over the place).
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → WONTFIX
Component: JavaScript Debugging/Profiling APIs → JavaScript Engine
You need to log in before you can comment on or make changes to this bug.