Closed Bug 611060 Opened 9 years ago Closed 9 years ago

Support both -r and -l in Disassemble, allow options in DisassFile

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: paul.biggar, Unassigned)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
-r and -l don't both work together, and no options are supported in DisassFile. this fixes both problems.
Attachment #489547 - Attachment is patch: true
Attachment #489547 - Attachment mime type: application/octet-stream → text/plain
Attachment #489547 - Flags: review?(igor)
Comment on attachment 489547 [details] [diff] [review]
patch

>+"dis([fun])               Disassemble functions into bytecodes",
>+"disfile('foo.js')        Disassemble script file into bytecodes\n"
>+"  dis() and disfile() can be preceeded with\n"
>+"    \"-r\" (disassemble recursively)\n"
>+"    \"-l\" (show line numbers)",


Nice help!
Attachment #489547 - Flags: review?(igor) → review+
(In reply to comment #1)
> Comment on attachment 489547 [details] [diff] [review]
> patch
> 
> >+"dis([fun])               Disassemble functions into bytecodes",
> >+"disfile('foo.js')        Disassemble script file into bytecodes\n"
> >+"  dis() and disfile() can be preceeded with\n"
> >+"    \"-r\" (disassemble recursively)\n"
> >+"    \"-l\" (show line numbers)",

Should add "arguments " before "can", or something like that. The "()" are a kind of post-fix <code>...</code> convention but not really helping here.

Try this:

"  Both dis and disfile take these options as leading string arguments:\n"

/be
http://hg.mozilla.org/mozilla-central/rev/12d38422c622
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.