Closed Bug 611071 Opened 15 years ago Closed 15 years ago

Move SearchForm out of the search view

Categories

(support.mozilla.org :: Code Quality, task, P3)

Product:
support.mozilla.org
Component:
Code Quality
Type:
task

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: jsocol, Assigned: paulc)

Details

(Whiteboard: [qa-])

The SearchForm is only in the view because, when categories were in the DB, you had to define the class at runtime to get the choices correct in tests. That's not true anymore (woot!). We can move the giant class that takes up half of search.views into search.forms. There probably also a good bit of refactoring that can be done in there at the same time, but for this bug let's just move the thing.
Okay it bugged me too much so I fixed it :)
Assignee: nobody → paulc
Target Milestone: Future → 2.4.1
https://github.com/jsocol/kitsune/commit/09a20b4e0cf1316def0e9218c22cb1d31347d614
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Whiteboard: [qa-]
Closing as [qa-] per paulc
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.