Move SearchForm out of the search view

VERIFIED FIXED in 2.4.1

Status

P3
normal
VERIFIED FIXED
8 years ago
8 years ago

People

(Reporter: jsocol, Assigned: paulc)

Tracking

unspecified
2.4.1

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

(Reporter)

Description

8 years ago
The SearchForm is only in the view because, when categories were in the DB, you had to define the class at runtime to get the choices correct in tests.

That's not true anymore (woot!).

We can move the giant class that takes up half of search.views into search.forms. There probably also a good bit of refactoring that can be done in there at the same time, but for this bug let's just move the thing.
(Assignee)

Comment 1

8 years ago
Okay it bugged me too much so I fixed it :)
Assignee: nobody → paulc
Target Milestone: Future → 2.4.1
(Assignee)

Comment 2

8 years ago
https://github.com/jsocol/kitsune/commit/09a20b4e0cf1316def0e9218c22cb1d31347d614
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(Assignee)

Updated

8 years ago
Whiteboard: [qa-]
Closing as [qa-] per paulc
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.