Closed Bug 611073 Opened 9 years ago Closed 9 years ago

Improve treechildren::-moz-tree-progressmeter performance

Categories

(Toolkit :: Themes, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla2.0b8

People

(Reporter: nmaier, Assigned: nmaier)

Details

Attachments

(1 file)

As observed in bug 593812 the rendering performance of progressbars in trees is bad, especially when using the not-yet-optimized D2D/hw-accelerated code.
This is due to the way the borders of such progressbars are drawn, namely the use of -moz-border-*-colors. (See bug 593812 comment 7 and bug 593812 comment 9)

The CSS can be easily improved for winstripe and gnomestripe to trigger better rendering paths, by using a single color for each border site and adding a 1px padding.
This is almost equivalent, except that the corner pixels might not be averaged from both border edge colors.
Replace the inner border color with a 1px padding, as the border color is the background color anyway.
The result is almost pixel-perfect, except the box corner pixels, but that minor difference is negligible.

Only winstripe and gnomestripe, as in pinestripe does not use the same color for the inner border and background.
Assignee: nobody → MaierMan
Status: NEW → ASSIGNED
Attachment #489565 - Flags: review?
Attachment #489565 - Flags: review? → review?(dao)
Attachment #489565 - Flags: review?(dao) → review+
Attachment #489565 - Flags: approval2.0?
Attachment #489565 - Flags: approval2.0? → approval2.0+
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/36ffe0ce3a00
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Component: XP Toolkit/Widgets: XUL → Themes
Keywords: checkin-needed
Product: Core → Toolkit
QA Contact: xptoolkit.xul → themes
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
You need to log in before you can comment on or make changes to this bug.