Closed Bug 611136 Opened 9 years ago Closed 9 years ago

Support WebPluginTypeEnabled key in com.apple.quicktime.plugin.preferences.plist

Categories

(Core :: Plug-ins, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
Tracking Status
blocking2.0 --- betaN+

People

(Reporter: sgreenlay, Assigned: sgreenlay)

References

Details

Attachments

(1 file, 8 obsolete files)

Currently we ignore the WebPluginTypeEnabled key and blacklist manually (bug 607444)
Assignee: nobody → sgreenlay
Attachment #489634 - Flags: review?(joshmoz)
Status: NEW → ASSIGNED
Given that this *might* fix bug 610715, I think we should get this reviewed and landed and then watch crash-stats to see if this solves the problem or not.

Josh, can you review? I'll gladly approve a reviewed patch for this. Worst case, if this doesn't solve the problem and causes other problems, we back out the change and dig deeper. Well worth the attempt IMO.
added NULL check to return from CFStringRefToUTF8Buffer (to ensure no NULL entries in info.fMimeTypeArray)
Attachment #489634 - Attachment is obsolete: true
Attachment #490152 - Flags: review?(joshmoz)
Attachment #489634 - Flags: review?(joshmoz)
Attachment #490152 - Attachment is obsolete: true
Attachment #490166 - Flags: review?(joshmoz)
Attachment #490152 - Flags: review?(joshmoz)
Comment on attachment 490166 [details] [diff] [review]
WebPluginTypeEnabled support (v1.2)

+static Boolean ShouldIgnoreMIMEType(CFBundleRef bundle, CFDictionaryRef mimeDict) {

Don't need the bundle argument.
Attachment #490166 - Flags: review?(joshmoz) → review-
Attachment #490166 - Attachment is obsolete: true
Attachment #490178 - Flags: review?(joshmoz)
Attachment #490178 - Attachment is obsolete: true
Attachment #490178 - Flags: review?(joshmoz)
Attachment #490256 - Flags: review?(joshmoz)
Attachment #490256 - Attachment is obsolete: true
Attachment #490256 - Flags: review?(joshmoz)
Attachment #490288 - Flags: review?(joshmoz)
Missed a '::' in front of a CoreFoundation call
Attachment #490288 - Attachment is obsolete: true
Attachment #490291 - Flags: review?(joshmoz)
Attachment #490288 - Flags: review?(joshmoz)
Comment on attachment 490291 [details] [diff] [review]
WebPluginTypeEnabled support (v1.6)

I think the logic for "ShouldIgnoreMIMEType" would be more clear if you flipped the meaning of the function to match the key you're looking at. Just name it 'MimeTypeEnabled' or something like that and return the value of "WebPluginTypeEnabled" if it exists and true by default.
Attachment #490291 - Attachment is obsolete: true
Attachment #490519 - Flags: review?(joshmoz)
Attachment #490291 - Flags: review?(joshmoz)
blocking2.0: --- → betaN+
Comment on attachment 490519 [details] [diff] [review]
WebPluginTypeEnabled support (v1.7)

>+static Boolean MimeTypeEnabled(CFDictionaryRef mimeDict) {
>+  if (mimeDict) {

Make this an early return to cut down a level of indentation.

>+        if (!CFBooleanGetValue(static_cast<CFBooleanRef>(value))) {
>+          return false;

Just return the result from "CFBooleanGetValue" instead of having an "if" statement and prefix it with "::".
Attachment #490519 - Attachment is obsolete: true
Attachment #490603 - Flags: review?(joshmoz)
Attachment #490519 - Flags: review?(joshmoz)
Attachment #490603 - Flags: review?(joshmoz) → review+
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Blocks: 610715
You need to log in before you can comment on or make changes to this bug.