611172 - Focus does not get reset on clicking outside the "Delete Add-on Version" pop-up

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, enhancement, P5)

Description

[krupa raj[:krupa]]

Attachment: screenshot

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.12) Gecko/20101026 Firefox/3.6.12

steps to reproduce:
1. Load https://addons.allizom.org/z/en-US/developers/addon/228515/versions/
2. Click on the delete icon for one of the listed versions
3. Notice the pop-up which is set to focus
4. Click anywhere outside of the pop-up

expected behavior:
Clicking outside of the pop-up is treated as a cancel, and focus is returned to the versions page

actual behavior:
On clicking anywhere outside of the pop-up box, the pop-up goes away but the focus is not reset to the versions page. See screenshot.

Comment 1

[Gregory Koberger (:gkoberger)]

https://github.com/jbalogh/zamboni/commit/400b3164c4b6f02c1e60cfc5db35321557123126

Comment 2

[krupa raj[:krupa]]

Moving the milestone to 5.12.3 based on-  

clouserw: bug 611172 has target milestone set to 5.12.4, but the fix is in next
fligtar: krupa: sounds like you should move the milestone then!
gkoberger: krupa: potch fixed it separately, and it was added to the codebase before the bug was filed

verified fixed @ https://addons-next.allizom.org/z/en-US/developers/addon/64250/versions/