[design] Two more questions for chowse's L10n brain child

RESOLVED FIXED in 5.12.4

Status

addons.mozilla.org Graveyard
Developer Pages
P1
normal
RESOLVED FIXED
7 years ago
2 years ago

People

(Reporter: clouserw, Assigned: potch)

Tracking

unspecified
5.12.4
Dependency tree / graph

Details

(Reporter)

Description

7 years ago
1) Some fields are not localizable (like the Add-on URL).  How do we communicate that to the user with the page-level L10n dropdown?

2) If I'm looking at the edit page (https://addons.allizom.org/z/en-US/developers/addon/5326/edit) but haven't clicked edit on anything so I don't see any forms.  What happens when I change the "localize for" dropdown?  I expect it to change the displayed content, but it doesn't.  Should it?
For reference to the questions below:
http://people.mozilla.com/~chowse/drop/amo/devtools/v3/interaction/localization.png

(In reply to comment #0)
> 1) Some fields are not localizable (like the Add-on URL).  How do we
> communicate that to the user with the page-level L10n dropdown?

Fields that are localizable will have a small 'locale' badge below their label, when the users switches to a non-US locale. See the second mock-up below 'Adding/Removing Translations': the 'Name' label has 'Italiano' below it in small print.


> 2) If I'm looking at the edit page
> (https://addons.allizom.org/z/en-US/developers/addon/5326/edit) but haven't
> clicked edit on anything so I don't see any forms.  What happens when I change
> the "localize for" dropdown?  I expect it to change the displayed content, but
> it doesn't.  Should it?

Yes, it should change in a few subtle ways:

1.) Localizable fields should gain a 'locale' badge below their labels (see 
    my response to the previous question). This should appear even if the
    section isn't being edited.

2.) If a field is localizable but has not been localized yet, the English
    value should be used, but it should appear in gray, italicized type.
    In the second mock-up below 'Adding/Removing Translations': notice how
    the 'Friendbook Search' (the original en-US value) looks. For comparison,
    look at the 5th mock-up: now that the field has been translated to 
    'Friendbook Search in Italiano', the text is darker and not italicized.

    Note: these style differences also apply while the field is being edited;
    see the 3rd and 4th mockup. And a small correction: in the last mock-up,
    the value (which has been changed back to its original English version)
    should be gray and italicized once more.
(Assignee)

Comment 2

7 years ago
Sounds like work for me!
Assignee: chowse → thepotch
(Assignee)

Updated

7 years ago
Target Milestone: 5.12.3 → 5.12.4
(Assignee)

Comment 3

7 years ago
https://github.com/jbalogh/zamboni/commit/f580e11fbb39e34
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED

Updated

7 years ago
Depends on: 615412
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.