Closed Bug 611433 Opened 9 years ago Closed 9 years ago

Let TBPL control hidden builds

Categories

(Tree Management Graveyard :: TBPL, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mstange, Assigned: mstange)

Details

Attachments

(1 file)

Attached patch v1Splinter Review
Tinderbox has a concept of hidden builds, but buildbot doesn't. So it's on TBPL to reject hidden builds that it receives from buildbot.
We'll want to store this list somewhere server side with a UI to change it, but for now let's just dump it into Config.js.
This patch also rejects hidden builds from the running / pending JSON.
Attachment #489890 - Flags: review?(arpad.borsos)
Comment on attachment 489890 [details] [diff] [review]
v1

(In reply to comment #0)
> Tinderbox has a concept of hidden builds, but buildbot doesn't. So it's on TBPL
> to reject hidden builds that it receives from buildbot.
> We'll want to store this list somewhere server side with a UI to change it, but
> for now let's just dump it into Config.js.

You are right, It is really ugly to have in Config.js, but it’s the best we can do now.

> This patch also rejects hidden builds from the running / pending JSON.

It *only* rejects running/pending builds for now.
Attachment #489890 - Flags: review?(arpad.borsos) → review+
http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/d1b63270706c
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Product: Webtools → Tree Management
Product: Tree Management → Tree Management Graveyard
You need to log in before you can comment on or make changes to this bug.