611469 - fennecmark appears to be overwriting the contents of the log file on quit

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

In looking at why fennecmark shows unrecognizable output in talos, I see that in many cases the log file is empty.  

After debugging, I found that we are getting accurate information, but after we call goQuitApplication we zero out the log file.  At first I thought this might have been other code (ipc extension, pageloader extension, etc...) causing problems, but it appears to be related to fennecmark itself.

Oddly enough if I put an alert("hello world"); call  after goQuitApplication, it displays the alert, then terminates.  The best part is the log file is not overwritten.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: fix fennecmark so it will only write one log depending on which mode you are in (1.0)

It appears that creating a nsiFile object was the culprit.  I have moved the entire creation of the local reporting into a separate section which won't be invoked if we are in talos mode.

Locally this produced green tpan results over and over again on android.

Comment 2

[Aki Sasaki (not active)]

Comment on attachment 490358 [details] [diff] [review]
fix fennecmark so it will only write one log depending on which mode you are in (1.0)

I'm going to stamp this.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

pushed:
http://hg.mozilla.org/users/tglek_mozilla.com/fennecmark/pushloghtml?changeset=bfc910cd8dd3

please update the fennecmark.tar|zip file used for talos