Closed Bug 611551 Opened 14 years ago Closed 13 years ago

Add version_int to the Version model

Categories

(addons.mozilla.org Graveyard :: Public Pages, defect, P2)

Product:
addons.mozilla.org Graveyard
Component:
Public Pages
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
5.12.12

People

(Reporter: jbalogh, Assigned: andy+bugzilla)

References

Details

(Whiteboard: [qa-]) 

version_int is derived from versions.compare.version_int and is the proper way to compare version numbers.  We should make sure it's set in Version.save() and migrate old versions to have the column.
Blocks: 612051
Assignee: nobody → amckay
No longer blocks: 612051
Target Milestone: Q4 2010 → Q1 2011
Priority: -- → P2
Target Milestone: Q1 2011 → 5.12.12
version_ints are overflowing the bigint column. So i'll probably just divide all version_ints by X and that will get most of the cases. The worst example so far is:

1237.2319.32161734.2383290.34

But other overflows include:

1.09.2008051801
Or just not write a version_int for them and only use it fits in our schema. I can see a scenario where we might get the wrong version if people start changing their version numbers however.
Why not use a varchar(255) instead of bigint?
A varchar won't give you the right sorting.
https://github.com/jbalogh/zamboni/commit/399d79c1aa87b4a0e3fe3887491d367188b70523
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Blocks: 476232
Whiteboard: [qa-]
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.