Closed
Bug 611551
Opened 15 years ago
Closed 14 years ago
Add version_int to the Version model
Categories
(addons.mozilla.org Graveyard :: Public Pages, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
5.12.12
People
(Reporter: jbalogh, Assigned: andy+bugzilla)
References
Details
(Whiteboard: [qa-])
version_int is derived from versions.compare.version_int and is the proper way to compare version numbers. We should make sure it's set in Version.save() and migrate old versions to have the column.
|
Assignee | |
Updated•15 years ago
|
Assignee: nobody → amckay
|
||
Updated•14 years ago
|
Target Milestone: Q4 2010 → Q1 2011
|
||
Updated•14 years ago
|
Priority: -- → P2
|
|
||
Updated•14 years ago
|
Target Milestone: Q1 2011 → 5.12.12
|
|
Assignee | |
Comment 1•14 years ago
|
||
version_ints are overflowing the bigint column. So i'll probably just divide all version_ints by X and that will get most of the cases. The worst example so far is:
1237.2319.32161734.2383290.34
But other overflows include:
1.09.2008051801
|
|
Assignee | |
Comment 2•14 years ago
|
||
Or just not write a version_int for them and only use it fits in our schema. I can see a scenario where we might get the wrong version if people start changing their version numbers however.
|
|
||
Comment 3•14 years ago
|
||
Why not use a varchar(255) instead of bigint?
|
|
Assignee | |
Comment 4•14 years ago
|
||
A varchar won't give you the right sorting.
|
|
Assignee | |
Comment 5•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•14 years ago
|
Whiteboard: [qa-]
|
||
Updated•9 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•